Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(169)

Unified Diff: runtime/bin/eventhandler.h

Issue 10693039: Terminate event handler thread on isolate shutdown. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Adding new file to gyp file Created 8 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « runtime/bin/builtin_impl_sources.gypi ('k') | runtime/bin/eventhandler.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/bin/eventhandler.h
diff --git a/runtime/bin/eventhandler.h b/runtime/bin/eventhandler.h
index eb428fd991e084e99a82f952151611b82d825586..5ba90f6822545f7dfd3936f69b84176e8271c580 100644
--- a/runtime/bin/eventhandler.h
+++ b/runtime/bin/eventhandler.h
@@ -6,6 +6,7 @@
#define BIN_EVENTHANDLER_H_
#include "bin/builtin.h"
+#include "bin/isolate_data.h"
// Flags used to provide information and actions to the eventhandler
// when sending a message about a file descriptor. These flags should
@@ -41,9 +42,16 @@ class EventHandler {
delegate_.SendData(id, dart_port, data);
}
- static EventHandler* StartEventHandler() {
+ void Shutdown() {
+ delegate_.Shutdown();
+ }
+
+ static EventHandler* Start() {
EventHandler* handler = new EventHandler();
- handler->delegate_.StartEventHandler();
+ handler->delegate_.Start();
+ IsolateData* isolate_data =
+ reinterpret_cast<IsolateData*>(Dart_CurrentIsolateData());
+ isolate_data->event_handler = handler;
return handler;
}
« no previous file with comments | « runtime/bin/builtin_impl_sources.gypi ('k') | runtime/bin/eventhandler.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698