Issue 10692186: Fix factory constructors unparse:

Issue 10692186: Fix factory constructors unparse: (Closed)

Created:
8 years, 5 months ago by Roman

Modified:
8 years, 5 months ago

Reviewers:
Anton Muhin

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Fix factory constructors unparse: class A{ A.fromFoo(); } => class A{ AfromFoo(); } and also print out initializers. Committed: https://code.google.com/p/dart/source/detail?r=9623

Patch Set 2 : #

Total comments: 3

Created: 8 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+21 lines, -1 line)			Patch
M	lib/compiler/implementation/dart_backend/emitter.dart	View	1	1 chunk	+2 lines, -1 line	0 comments	Download
M	lib/compiler/implementation/tree/unparser.dart	View	1	2 chunks	+10 lines, -0 lines	3 comments	Download
M	tests/compiler/dart2js/unparser_test.dart	View	1	3 chunks	+9 lines, -0 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Anton Muhin

lgtm https://chromiumcodereview.appspot.com/10692186/diff/2002/lib/compiler/implementation/tree/unparser.dart File lib/compiler/implementation/tree/unparser.dart (right): https://chromiumcodereview.appspot.com/10692186/diff/2002/lib/compiler/implementation/tree/unparser.dart#newcode86 lib/compiler/implementation/tree/unparser.dart:86: if (node.modifiers !== null && node.modifiers.nodes.length() > 0) ...

8 years, 5 months ago (2012-07-13 07:07:21 UTC) #2

Roman

https://chromiumcodereview.appspot.com/10692186/diff/2002/lib/compiler/implementation/tree/unparser.dart File lib/compiler/implementation/tree/unparser.dart (right): https://chromiumcodereview.appspot.com/10692186/diff/2002/lib/compiler/implementation/tree/unparser.dart#newcode86 lib/compiler/implementation/tree/unparser.dart:86: if (node.modifiers !== null && node.modifiers.nodes.length() > 0) { ...

8 years, 5 months ago (2012-07-13 08:14:57 UTC) #3

Anton Muhin

8 years, 5 months ago (2012-07-13 08:15:47 UTC) #4

still lgtm

https://chromiumcodereview.appspot.com/10692186/diff/2002/lib/compiler/implem...
File lib/compiler/implementation/tree/unparser.dart (right):

https://chromiumcodereview.appspot.com/10692186/diff/2002/lib/compiler/implem...
lib/compiler/implementation/tree/unparser.dart:86: if (node.modifiers !== null
&& node.modifiers.nodes.length() > 0) {
Thanks a lot for explanations, Roma.

On 2012/07/13 08:14:57, Roman wrote:
> On 2012/07/13 07:07:21, Anton Mukhin wrote:
> > are both cases possible, both null and empty list?
> 
> I added null check after I got "noSuchMethod" error, and empty list happens
very
> often.

Expand Messages | Collapse Messages