Fix factory constructors unparse:

lib/compiler/implementation/tree/unparser.dart

 // Copyright (c) 2012, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 class Unparser implements Visitor {
   StringBuffer sb;
 
   Unparser();
 
   String unparse(Node node) {
@@ skipping 64 matching lines @@
     visit(node.update);
     sb.add(')');
     visit(node.body);
   }
 
   visitFunctionDeclaration(FunctionDeclaration node) {
     visit(node.function);
   }
 
   visitFunctionExpression(FunctionExpression node) {
+    // Check length to not print unnecessary whitespace.
+    if (node.modifiers !== null && node.modifiers.nodes.length() > 0) {

[Anton Muhin, 2012/07/13 07:07:21]

are both cases possible, both null and empty list?

[Roman, 2012/07/13 08:14:57]

I added null check after I got "noSuchMethod" error, and empty list happens very
often.

[Anton Muhin, 2012/07/13 08:15:47]

Thanks a lot for explanations, Roma.

On 2012/07/13 08:14:57, Roman wrote:

+      visit(node.modifiers);
+      sb.add(' ');
+    }
     if (node.returnType !== null) {
       visit(node.returnType);
       sb.add(' ');
     }
     if (node.getOrSet !== null) {
       add(node.getOrSet.value);
       sb.add(' ');
     }
     // TODO(antonm): that's a workaround as currently FunctionExpression
     // names are modelled with Send and it emits operator[] as only
     // operator, without [] which are expected to be emitted with
     // arguments.
     if (node.name is Send) {
       Send send = node.name;
       assert(send is !SendSet);
       visit(send.receiver);
+      if (!send.isOperator) {
+        // Looks like a factory method.
+        sb.add('.');
+      }
       visit(send.selector);
     } else {
       visit(node.name);
     }
     visit(node.parameters);
+    visit(node.initializers);
     visit(node.body);
   }
 
   visitIdentifier(Identifier node) {
     add(node.token.value);
   }
 
   visitIf(If node) {
     add(node.ifToken.value);
     visit(node.condition);
@@ skipping 346 matching lines @@
       sb.add(' ');
     }
     visit(node.name);
     if (node.typeParameters !== null) {
       visit(node.typeParameters);
     }
     visit(node.formals);
     add(node.endToken.value);
   }
 }