Issue 10689169: Use environment variables to find the Dart SDK and the Pub cache directory.

Issue 10689169: Use environment variables to find the Dart SDK and the Pub cache directory. (Closed)

Created:
8 years, 5 months ago by nweiz

Modified:
8 years, 5 months ago

Reviewers:
Bob Nystrom

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Use environment variables to find the Dart SDK and the Pub cache directory. Committed: https://code.google.com/p/dart/source/detail?r=9615

Patch Set 2 : Code review changes #

Created: 8 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+45 lines, -45 lines)			Patch
M	utils/pub/io.dart	View	1	1 chunk	+3 lines, -1 line	0 comments	Download
M	utils/pub/pub.dart	View		3 chunks	+14 lines, -7 lines	0 comments	Download
M	utils/pub/sdk_source.dart	View	1	2 chunks	+8 lines, -4 lines	0 comments	Download
M	utils/tests/pub/pub_test.dart	View		1 chunk	+0 lines, -2 lines	0 comments	Download
M	utils/tests/pub/test_pub.dart	View		2 chunks	+20 lines, -31 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Bob Nystrom

https://chromiumcodereview.appspot.com/10689169/diff/1/utils/pub/io.dart File utils/pub/io.dart (right): https://chromiumcodereview.appspot.com/10689169/diff/1/utils/pub/io.dart#newcode336 utils/pub/io.dart:336: [workingDir, environment, bool pipeStdout = false, Can you type ...

8 years, 5 months ago (2012-07-12 16:49:27 UTC) #2

nweiz

8 years, 5 months ago (2012-07-12 18:44:30 UTC) #3

Bob Nystrom

8 years, 5 months ago (2012-07-12 21:07:57 UTC) #4

LGTM!

https://chromiumcodereview.appspot.com/10689169/diff/1/utils/pub/sdk_source.dart
File utils/pub/sdk_source.dart (right):

https://chromiumcodereview.appspot.com/10689169/diff/1/utils/pub/sdk_source.d...
utils/pub/sdk_source.dart:29: throw "Pub can't find the Dart SDK. Please set the
DART_SDK environment "
On 2012/07/12 18:44:30, nweiz wrote:
> On 2012/07/12 16:49:27, Bob Nystrom wrote:
> > Instead of checking here, why not having the constructor validate it? Do we
> want
> > to allow SdkSource instances without a root directory?
> 
> We want pub to work without DART_SDK if it doesn't need anything from the SDK
> anyway (e.g. just installing from Git or the repo).

OK, cool.

Expand Messages | Collapse Messages