Use environment variables to find the Dart SDK and the Pub cache directory.

utils/pub/sdk_source.dart

 // Copyright (c) 2012, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 #library('sdk_source');
 
 #import('io.dart');
 #import('package.dart');
 #import('source.dart');
 
 /**
  * A package source that uses libraries from the Dart SDK.
  *
  * This currently uses the "sdkdir" command-line argument to find the SDK.
  */
 // TODO(nweiz): This should read the SDK directory from an environment variable
 // once we can set those for tests.

[Bob Nystrom, 2012/07/12 16:49:27]

Remove this TODO.

[nweiz, 2012/07/12 18:44:30]

Done.

 class SdkSource extends Source {
   final String name = "sdk";
   final bool shouldCache = false;
 
   /**
    * The root directory of the Dart SDK.
    */
-  final String rootDir;
+  final String _rootDir;
 
-  SdkSource(this.rootDir);
+  String get rootDir() {
+    if (_rootDir != null) return _rootDir;
+    throw "Pub can't find the Dart SDK. Please set the DART_SDK environment "

[Bob Nystrom, 2012/07/12 16:49:27]

Instead of checking here, why not having the constructor validate it? Do we want
to allow SdkSource instances without a root directory?

[nweiz, 2012/07/12 18:44:30]

We want pub to work without DART_SDK if it doesn't need anything from the SDK
anyway (e.g. just installing from Git or the repo).

[Bob Nystrom, 2012/07/12 21:07:57]

OK, cool.

+      "variable to the Dart SDK directory.";
+  }
+
+  SdkSource(this._rootDir);
 
   /**
    * An SDK package has no dependencies. Its version number is inferred from the
    * revision number of the SDK itself.
    */
   Future<Pubspec> describe(PackageId id) {
     return readTextFile(join(rootDir, "revision")).transform((revision) =>
         new Pubspec("0.0.0-r.${revision.trim()}", <PackageRef>[]));
   }
 
   /**
    * Since all the SDK files are already available locally, installation just
    * involves symlinking the SDK library into the packages directory.
    */
   Future<bool> install(PackageId id, String destPath) {
     var sourcePath = join(rootDir, "lib", id.description);
     return exists(sourcePath).chain((exists) {
       if (!exists) return new Future<bool>.immediate(false);
       return createSymlink(sourcePath, destPath).transform((_) => true);
     });
   }
 }