Issue 10689065: Deal with special cmd.exe environment variables that have keys that start with an equals sign.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10689065: Deal with special cmd.exe environment variables that have keys that start with an equals sign. (Closed)

Created:
8 years, 5 months ago by Mads Ager (google)

Modified:
8 years, 5 months ago

Reviewers:
Johnni Winther

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Deal with special cmd.exe environment variables that have keys that start with an equals sign. I have attempted to deal with them correctly instead of ignoring them so that they can be passed on unchanged to subprocesses. R=johnniwinther@google.com BUG= TEST= Committed: https://code.google.com/p/dart/source/detail?r=9284

Patch Set 1 #

Created: 8 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+10 lines, -4 lines)			Patch
	M	runtime/bin/platform_impl.dart	View		1 chunk	+10 lines, -0 lines	0 comments	Download
	M	runtime/bin/process_impl.dart	View		1 chunk	+0 lines, -4 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

lgtm

Expand Messages | Collapse Messages