Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(529)

Unified Diff: runtime/bin/process_impl.dart

Issue 10689065: Deal with special cmd.exe environment variables that have keys that start with an equals sign. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 8 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « runtime/bin/platform_impl.dart ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/bin/process_impl.dart
diff --git a/runtime/bin/process_impl.dart b/runtime/bin/process_impl.dart
index e2ba3e654576f856d059f2828b03165d98f590d5..00ddeae67a024d4a29a001e4cbe16920e12e206a 100644
--- a/runtime/bin/process_impl.dart
+++ b/runtime/bin/process_impl.dart
@@ -64,10 +64,6 @@ class _Process extends Process {
throw new IllegalArgumentException(
"Environment key or value is not a string: ($key, $value)");
}
- if (key.contains('=')) {
- throw new IllegalArgumentException(
- "Environment keys may not contain '=': $key");
- }
_environment.add('$key=$value');
});
}
« no previous file with comments | « runtime/bin/platform_impl.dart ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698