Associate partial source map with each code block in Universe.generatedCode.

Associate partial source map with each code block in Universe.generatedCode.

That way we can create partial source maps for individual functions in codegen,
and join them into a single map at the end.

Currently partial source maps contain only begin and end positions of all functions.

R=ahe@google.com

Committed: https://code.google.com/p/dart/source/detail?r=9400

[podivilov, 2012-07-02 14:30:21]

Florian, could you please take a look?

[floitsch, 2012-07-02 15:18:32]

LGTM.

https://chromiumcodereview.appspot.com/10668029/diff/1/lib/compiler/implement...
File lib/compiler/implementation/emitter.dart (right):

https://chromiumcodereview.appspot.com/10668029/diff/1/lib/compiler/implement...
lib/compiler/implementation/emitter.dart:1060: typedef void
DefineInstanceMember(String invocationName,
DefineInstanceMemberFunction ?
imho it reads strange otherwise.

https://chromiumcodereview.appspot.com/10668029/diff/1/lib/compiler/implement...
File lib/compiler/implementation/ssa/codegen.dart (right):

https://chromiumcodereview.appspot.com/10668029/diff/1/lib/compiler/implement...
lib/compiler/implementation/ssa/codegen.dart:2942: class SourceMappingEntry {
I don't think these classes belong here.
The CodeBlock should be at least at compiler level and the SourceMappingEntry
probably somewhere in the source-mapping files.

[podivilov, 2012-07-03 13:08:49]

Thanks!

https://chromiumcodereview.appspot.com/10668029/diff/1/lib/compiler/implement...
File lib/compiler/implementation/emitter.dart (right):

https://chromiumcodereview.appspot.com/10668029/diff/1/lib/compiler/implement...
lib/compiler/implementation/emitter.dart:1060: typedef void
DefineInstanceMember(String invocationName,
On 2012/07/02 15:18:32, floitsch wrote:
> DefineInstanceMemberFunction ?
> imho it reads strange otherwise.

Done.

https://chromiumcodereview.appspot.com/10668029/diff/1/lib/compiler/implement...
File lib/compiler/implementation/ssa/codegen.dart (right):

https://chromiumcodereview.appspot.com/10668029/diff/1/lib/compiler/implement...
lib/compiler/implementation/ssa/codegen.dart:2942: class SourceMappingEntry {
On 2012/07/02 15:18:32, floitsch wrote:
> I don't think these classes belong here.
> The CodeBlock should be at least at compiler level and the SourceMappingEntry
> probably somewhere in the source-mapping files.

Moved CodeBlock to universe.dart. Please let me know if there's a better place.

[ahe, 2012-08-02 20:34:56]

https://chromiumcodereview.appspot.com/10668029/diff/1/lib/compiler/implement...
File lib/compiler/implementation/dart2js.dart (left):

https://chromiumcodereview.appspot.com/10668029/diff/1/lib/compiler/implement...
lib/compiler/implementation/dart2js.dart:245: code = '$code\n//@
sourceMappingURL=${relativize(out, sourceMapOut)}';
Doesn't this mean that we ignore source maps?

[podivilov, 2012-08-21 12:29:35]

https://chromiumcodereview.appspot.com/10668029/diff/1/lib/compiler/implement...
File lib/compiler/implementation/dart2js.dart (left):

https://chromiumcodereview.appspot.com/10668029/diff/1/lib/compiler/implement...
lib/compiler/implementation/dart2js.dart:245: code = '$code\n//@
sourceMappingURL=${relativize(out, sourceMapOut)}';
On 2012/08/02 20:34:56, ahe wrote:
> Doesn't this mean that we ignore source maps?

I think dart2js shouldn't inject sourceMappingURL comment into compiled code.
You may want to use X-SourceMap http header to link compiled code to source map.
And it is easier to append new sourceMappingURL comment than fixing existing one
in case the relative path changed or you want to use absolute paths for source
maps on your server.

[ahe, 2012-08-21 12:42:32]

https://chromiumcodereview.appspot.com/10668029/diff/1/lib/compiler/implement...
File lib/compiler/implementation/dart2js.dart (left):

https://chromiumcodereview.appspot.com/10668029/diff/1/lib/compiler/implement...
lib/compiler/implementation/dart2js.dart:245: code = '$code\n//@
sourceMappingURL=${relativize(out, sourceMapOut)}';
On 2012/08/21 12:29:35, podivilov wrote:
> On 2012/08/02 20:34:56, ahe wrote:
> > Doesn't this mean that we ignore source maps?
> 
> I think dart2js shouldn't inject sourceMappingURL comment into compiled code.
> You may want to use X-SourceMap http header to link compiled code to source
map.
> And it is easier to append new sourceMappingURL comment than fixing existing
one
> in case the relative path changed or you want to use absolute paths for source
> maps on your server.

How do we enable source maps by default without having a special HTTP server?

[podivilov, 2012-08-21 17:04:25]

https://chromiumcodereview.appspot.com/10668029/diff/1/lib/compiler/implement...
File lib/compiler/implementation/dart2js.dart (left):

https://chromiumcodereview.appspot.com/10668029/diff/1/lib/compiler/implement...
lib/compiler/implementation/dart2js.dart:245: code = '$code\n//@
sourceMappingURL=${relativize(out, sourceMapOut)}';
On 2012/08/21 12:42:32, ahe wrote:
> On 2012/08/21 12:29:35, podivilov wrote:
> > On 2012/08/02 20:34:56, ahe wrote:
> > > Doesn't this mean that we ignore source maps?
> > 
> > I think dart2js shouldn't inject sourceMappingURL comment into compiled
code.
> > You may want to use X-SourceMap http header to link compiled code to source
> map.
> > And it is easier to append new sourceMappingURL comment than fixing existing
> one
> > in case the relative path changed or you want to use absolute paths for
source
> > maps on your server.
> 
> How do we enable source maps by default without having a special HTTP server?

Should we enable them by default? One can easily append the comment as a
deployment step if needed.

[ahe, 2012-08-22 09:39:43]

https://chromiumcodereview.appspot.com/10668029/diff/1/lib/compiler/implement...
File lib/compiler/implementation/dart2js.dart (left):

https://chromiumcodereview.appspot.com/10668029/diff/1/lib/compiler/implement...
lib/compiler/implementation/dart2js.dart:245: code = '$code\n//@
sourceMappingURL=${relativize(out, sourceMapOut)}';
On 2012/08/21 17:04:25, podivilov wrote:
> On 2012/08/21 12:42:32, ahe wrote:
> > On 2012/08/21 12:29:35, podivilov wrote:
> > > On 2012/08/02 20:34:56, ahe wrote:
> > > > Doesn't this mean that we ignore source maps?
> > > 
> > > I think dart2js shouldn't inject sourceMappingURL comment into compiled
> code.
> > > You may want to use X-SourceMap http header to link compiled code to
source
> > map.
> > > And it is easier to append new sourceMappingURL comment than fixing
existing
> > one
> > > in case the relative path changed or you want to use absolute paths for
> source
> > > maps on your server.
> > 
> > How do we enable source maps by default without having a special HTTP
server?
> 
> Should we enable them by default? One can easily append the comment as a
> deployment step if needed.

I think the default behavior should be to enable source maps by default. We can
later consider if there should be an option to not enable them.