Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(408)

Unified Diff: lib/compiler/implementation/dart2js.dart

Issue 10668029: Associate partial source map with each code block in Universe.generatedCode. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 8 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: lib/compiler/implementation/dart2js.dart
diff --git a/lib/compiler/implementation/dart2js.dart b/lib/compiler/implementation/dart2js.dart
index a4ce8c0ad021f619be40926d78c1adb932a2968a..9f01d36374400e97c6523a989d15bb8422fb4eb4 100644
--- a/lib/compiler/implementation/dart2js.dart
+++ b/lib/compiler/implementation/dart2js.dart
@@ -242,7 +242,6 @@ void compile(List<String> argv) {
if (code === null) {
fail('Error: Compilation failed.');
}
- code = '$code\n//@ sourceMappingURL=${relativize(out, sourceMapOut)}';
ahe 2012/08/02 20:34:56 Doesn't this mean that we ignore source maps?
podivilov 2012/08/21 12:29:35 I think dart2js shouldn't inject sourceMappingURL
ahe 2012/08/21 12:42:32 How do we enable source maps by default without ha
podivilov 2012/08/21 17:04:25 Should we enable them by default? One can easily a
ahe 2012/08/22 09:39:43 I think the default behavior should be to enable s
writeString(out, code);
int jsBytesWritten = code.length;
info('compiled $dartBytesRead bytes Dart -> $jsBytesWritten bytes JS '

Powered by Google App Engine
This is Rietveld 408576698