Issue 10659037: Issue 3839. Warn when 'dart:io' and 'dart:html' are used in single library

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10659037: Issue 3839. Warn when 'dart:io' and 'dart:html' are used in single library (Closed)

Created:
8 years, 6 months ago by scheglov

Modified:
8 years, 6 months ago

Reviewers:
Brian Wilkerson

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Issue 3839. Warn when 'dart:io' and 'dart:html' are used in single library http://code.google.com/p/dart/issues/detail?id=3839 R=brianwilkerson@google.com BUG= TEST= Committed: https://code.google.com/p/dart/source/detail?r=9133

Patch Set 1 #

Total comments: 1

Patch Set 2 : Report Editor specific warning as ErrorSeverity.INFO #

Created: 8 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+40 lines, -3 lines)			Patch
M	compiler/java/com/google/dart/compiler/DartCompiler.java	View	1	1 chunk	+11 lines, -1 line	0 comments	Download
M	compiler/java/com/google/dart/compiler/DartCompilerErrorCode.java	View	1	1 chunk	+2 lines, -0 lines	0 comments	Download
M	compiler/javatests/com/google/dart/compiler/end2end/inc/IncrementalCompilation2Test.java	View		1 chunk	+24 lines, -0 lines	0 comments	Download
M	editor/tools/plugins/com.google.dart.tools.core/src/com/google/dart/tools/core/analysis/AnalysisMarkerManager.java	View	1	1 chunk	+3 lines, -2 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Brian Wilkerson

8 years, 6 months ago (2012-06-26 18:55:05 UTC) #2

Other than the one comment, LGTM.

https://chromiumcodereview.appspot.com/10659037/diff/1/compiler/java/com/goog...
File compiler/java/com/google/dart/compiler/DartCompilerErrorCode.java (right):

https://chromiumcodereview.appspot.com/10659037/diff/1/compiler/java/com/goog...
compiler/java/com/google/dart/compiler/DartCompilerErrorCode.java:11:
CONSOLE_WEB_MIX(ErrorSeverity.WARNING,
This needs to be something that can be distinguished from a warning created
because of the specification so that we can allow users to decide whether or not
to display it.

Expand Messages | Collapse Messages