Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(660)

Unified Diff: editor/tools/plugins/com.google.dart.tools.core/src/com/google/dart/tools/core/analysis/AnalysisMarkerManager.java

Issue 10659037: Issue 3839. Warn when 'dart:io' and 'dart:html' are used in single library (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Report Editor specific warning as ErrorSeverity.INFO Created 8 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « compiler/javatests/com/google/dart/compiler/end2end/inc/IncrementalCompilation2Test.java ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: editor/tools/plugins/com.google.dart.tools.core/src/com/google/dart/tools/core/analysis/AnalysisMarkerManager.java
diff --git a/editor/tools/plugins/com.google.dart.tools.core/src/com/google/dart/tools/core/analysis/AnalysisMarkerManager.java b/editor/tools/plugins/com.google.dart.tools.core/src/com/google/dart/tools/core/analysis/AnalysisMarkerManager.java
index 4d2d74cd4709831b1637ead293ffae04324ea74a..b5a1a28ed7354b5068552d327b38c9028aede838 100644
--- a/editor/tools/plugins/com.google.dart.tools.core/src/com/google/dart/tools/core/analysis/AnalysisMarkerManager.java
+++ b/editor/tools/plugins/com.google.dart.tools.core/src/com/google/dart/tools/core/analysis/AnalysisMarkerManager.java
@@ -67,11 +67,12 @@ public class AnalysisMarkerManager implements AnalysisListener {
}
int severity;
+ ErrorSeverity errorSeverity = error.getErrorCode().getErrorSeverity();
if (error.getErrorCode().getSubSystem() == SubSystem.STATIC_TYPE) {
severity = IMarker.SEVERITY_WARNING;
- } else if (error.getErrorCode().getErrorSeverity() == ErrorSeverity.ERROR) {
+ } else if (errorSeverity == ErrorSeverity.ERROR) {
severity = IMarker.SEVERITY_ERROR;
- } else if (error.getErrorCode().getErrorSeverity() == ErrorSeverity.WARNING) {
+ } else if (errorSeverity == ErrorSeverity.WARNING || errorSeverity == ErrorSeverity.INFO) {
severity = IMarker.SEVERITY_WARNING;
} else {
return;
« no previous file with comments | « compiler/javatests/com/google/dart/compiler/end2end/inc/IncrementalCompilation2Test.java ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698