Issue 10641018: - Remove extra jumps from store barrier on x64.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10641018: - Remove extra jumps from store barrier on x64. (Closed)

Created:
8 years, 6 months ago by Ivan Posva

Modified:
8 years, 6 months ago

Reviewers:
Vyacheslav Egorov (Google), srdjan

CC:
reviews_dartlang.org

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

More Reviews

Description

- Remove extra jumps from store barrier on x64. Committed: https://code.google.com/p/dart/source/detail?r=9014

Patch Set 1 #

Total comments: 1

Created: 8 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+23 lines, -11 lines)			Patch
M	runtime/vm/assembler_ia32.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	runtime/vm/assembler_x64.h	View	1 chunk	+2 lines, -0 lines	0 comments	Download
M	runtime/vm/assembler_x64.cc	View	4 chunks	+20 lines, -10 lines	1 comment	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Vyacheslav Egorov (Google)

8 years, 6 months ago (2012-06-22 10:36:28 UTC) #2

lgtm

https://chromiumcodereview.appspot.com/10641018/diff/1/runtime/vm/assembler_x...
File runtime/vm/assembler_x64.cc (right):

https://chromiumcodereview.appspot.com/10641018/diff/1/runtime/vm/assembler_x...
runtime/vm/assembler_x64.cc:882: void Assembler::adcl(Register dst, Register
src) {
please add a test for this instruction in assembler tests

Expand Messages | Collapse Messages