Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(212)

Side by Side Diff: runtime/vm/assembler_ia32.cc

Issue 10641018: - Remove extra jumps from store barrier on x64. (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: Created 8 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « no previous file | runtime/vm/assembler_x64.h » ('j') | runtime/vm/assembler_x64.cc » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2011, the Dart project authors. Please see the AUTHORS file 1 // Copyright (c) 2011, the Dart project authors. Please see the AUTHORS file
2 // for details. All rights reserved. Use of this source code is governed by a 2 // for details. All rights reserved. Use of this source code is governed by a
3 // BSD-style license that can be found in the LICENSE file. 3 // BSD-style license that can be found in the LICENSE file.
4 4
5 #include "vm/globals.h" 5 #include "vm/globals.h"
6 #if defined(TARGET_ARCH_IA32) 6 #if defined(TARGET_ARCH_IA32)
7 7
8 #include "vm/assembler.h" 8 #include "vm/assembler.h"
9 #include "vm/heap.h" 9 #include "vm/heap.h"
10 #include "vm/memory_region.h" 10 #include "vm/memory_region.h"
(...skipping 1374 matching lines...) Expand 10 before | Expand all | Expand 10 after
1385 1385
1386 1386
1387 void Assembler::StoreIntoObjectFilter(Register object, 1387 void Assembler::StoreIntoObjectFilter(Register object,
1388 Register value, 1388 Register value,
1389 Label* no_update) { 1389 Label* no_update) {
1390 andl(value, Immediate(0x5)); 1390 andl(value, Immediate(0x5));
1391 shrl(value, Immediate(1)); 1391 shrl(value, Immediate(1));
1392 adcl(value, object); 1392 adcl(value, object);
1393 andl(value, Immediate(0x7)); 1393 andl(value, Immediate(0x7));
1394 cmpl(value, Immediate(0x4)); 1394 cmpl(value, Immediate(0x4));
1395 j(NOT_ZERO, no_update); 1395 j(NOT_ZERO, no_update, Assembler::kNearJump);
1396 } 1396 }
1397 1397
1398 1398
1399 void Assembler::StoreIntoObject(Register object, 1399 void Assembler::StoreIntoObject(Register object,
1400 const FieldAddress& dest, 1400 const FieldAddress& dest,
1401 Register value) { 1401 Register value) {
1402 movl(dest, value); 1402 movl(dest, value);
1403 Label done; 1403 Label done;
1404 pushl(value); 1404 pushl(value);
1405 StoreIntoObjectFilter(object, value, &done); 1405 StoreIntoObjectFilter(object, value, &done);
(...skipping 325 matching lines...) Expand 10 before | Expand all | Expand 10 after
1731 comments.SetCommentAt(i, comments_[i]->comment()); 1731 comments.SetCommentAt(i, comments_[i]->comment());
1732 } 1732 }
1733 1733
1734 return comments; 1734 return comments;
1735 } 1735 }
1736 1736
1737 1737
1738 } // namespace dart 1738 } // namespace dart
1739 1739
1740 #endif // defined TARGET_ARCH_IA32 1740 #endif // defined TARGET_ARCH_IA32
OLDNEW
« no previous file with comments | « no previous file | runtime/vm/assembler_x64.h » ('j') | runtime/vm/assembler_x64.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698