Issue 10636038: Minimize differences between ia32 and x64 sources to facilitate maintenance.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10636038: Minimize differences between ia32 and x64 sources to facilitate maintenance. (Closed)

Created:
8 years, 5 months ago by regis

Modified:
8 years, 5 months ago

Reviewers:
srdjan

CC:
reviews_dartlang.org

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

More Reviews

Description

Minimize differences between ia32 and x64 sources to facilitate maintenance. Committed: https://code.google.com/p/dart/source/detail?r=9089

Patch Set 2 : #

Created: 8 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+637 lines, -637 lines)			Patch
M	runtime/vm/code_generator_ia32.cc	View	1	1 chunk	+2 lines, -2 lines	0 comments	Download
M	runtime/vm/flow_graph_compiler.cc	View	1	1 chunk	+2 lines, -0 lines	0 comments	Download
M	runtime/vm/flow_graph_compiler_ia32.h	View	1	7 chunks	+35 lines, -37 lines	0 comments	Download
M	runtime/vm/flow_graph_compiler_ia32.cc	View	1	14 chunks	+451 lines, -441 lines	0 comments	Download
M	runtime/vm/flow_graph_compiler_x64.h	View	1	2 chunks	+0 lines, -2 lines	0 comments	Download
M	runtime/vm/flow_graph_compiler_x64.cc	View	1	28 chunks	+147 lines, -155 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

srdjan

LGTM https://chromiumcodereview.appspot.com/10636038/diff/1/runtime/vm/flow_graph_compiler_ia32.cc File runtime/vm/flow_graph_compiler_ia32.cc (right): https://chromiumcodereview.appspot.com/10636038/diff/1/runtime/vm/flow_graph_compiler_ia32.cc#newcode21 runtime/vm/flow_graph_compiler_ia32.cc:21: DEFINE_FLAG(bool, trace_functions, false, "Trace entry of each function."); ...

8 years, 5 months ago (2012-06-25 22:18:17 UTC) #2

regis

8 years, 5 months ago (2012-06-25 22:22:59 UTC) #3

Thanks!

https://chromiumcodereview.appspot.com/10636038/diff/1/runtime/vm/flow_graph_...
File runtime/vm/flow_graph_compiler_ia32.cc (right):

https://chromiumcodereview.appspot.com/10636038/diff/1/runtime/vm/flow_graph_...
runtime/vm/flow_graph_compiler_ia32.cc:21: DEFINE_FLAG(bool, trace_functions,
false, "Trace entry of each function.");
On 2012/06/25 22:18:17, srdjan wrote:
> How about moving them into flow_graph_compiler.cc ?

Done.

Expand Messages | Collapse Messages

Issue 10636038: Minimize differences between ia32 and x64 sources to facilitate maintenance. (Closed)

Description

Patch Set 1 #

Patch Set 2 : #

Messages