Minimize differences between ia32 and x64 sources to facilitate maintenance.

runtime/vm/flow_graph_compiler_ia32.h

 // Copyright (c) 2012, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 #ifndef VM_FLOW_GRAPH_COMPILER_IA32_H_
 #define VM_FLOW_GRAPH_COMPILER_IA32_H_
 
 #ifndef VM_FLOW_GRAPH_COMPILER_H_
 #error Include flow_graph_compiler.h instead of flow_graph_compiler_ia32.h.
 #endif
 
 namespace dart {
 
-class AbstractType;
-class Assembler;
 class Code;
 class DeoptimizationStub;
-class FlowGraphCompiler;
 template <typename T> class GrowableArray;
 class ParsedFunction;
-class StackMapBuilder;
 
-
-// Stubbed out implementation of graph compiler, bails out immediately if
-// CompileGraph is called. The rest of the public API is UNIMPLEMENTED.
 class FlowGraphCompiler : public ValueObject {
  private:
   struct BlockInfo : public ZoneAllocated {
    public:
     BlockInfo() : label() { }
     Label label;
   };
 
  public:
   FlowGraphCompiler(Assembler* assembler,
@@ skipping 37 matching lines @@
 
   // Returns 'true' if code generation for this function is complete, i.e.,
   // no fall-through to regular code is needed.
   bool TryIntrinsify();
 
   void GenerateCallRuntime(intptr_t cid,
                            intptr_t token_pos,
                            intptr_t try_index,
                            const RuntimeEntry& entry);
 
-  // Returns pc-offset (in bytes) of the pc after the call, can be used to emit
-  // pc-descriptor information.
-  intptr_t EmitStaticCall(const Function& function,
-                          const Array& arguments_descriptor,
-                          intptr_t argument_count);
-
   void GenerateCall(intptr_t token_pos,
                     intptr_t try_index,
                     const ExternalLabel* label,
                     PcDescriptors::Kind kind);
-  void GenerateInstanceOf(intptr_t cid,
-                          intptr_t token_pos,
-                          intptr_t try_index,
-                          const AbstractType& type,
-                          bool negate_result);
+
   void GenerateAssertAssignable(intptr_t cid,
                                 intptr_t token_pos,
                                 intptr_t try_index,
                                 const AbstractType& dst_type,
                                 const String& dst_name);
 
+  void GenerateInstanceOf(intptr_t cid,
+                          intptr_t token_pos,
+                          intptr_t try_index,
+                          const AbstractType& type,
+                          bool negate_result);
+
   void GenerateInstanceCall(intptr_t cid,
                             intptr_t token_pos,
                             intptr_t try_index,
                             const String& function_name,
                             intptr_t argument_count,
                             const Array& argument_names,
                             intptr_t checked_argument_count);
 
   void GenerateStaticCall(intptr_t cid,
                           intptr_t token_pos,
                           intptr_t try_index,
                           const Function& function,
                           intptr_t argument_count,
                           const Array& argument_names);
 
   void GenerateInlinedMathSqrt(Label* done);
 
   void GenerateNumberTypeCheck(Register kClassIdReg,
                                const AbstractType& type,
                                Label* is_instance_lbl,
                                Label* is_not_instance_lbl);
   void GenerateStringTypeCheck(Register kClassIdReg,
                                Label* is_instance_lbl,
                                Label* is_not_instance_lbl);
   void GenerateListTypeCheck(Register kClassIdReg,
                              Label* is_instance_lbl);
 
+  void EmitComment(Instruction* instr);
+
+  void EmitClassChecksNoSmi(const ICData& ic_data,
+                            Register instance_reg,
+                            Register temp_reg,
+                            Label* deopt);
+
   // Returns pc-offset (in bytes) of the pc after the call, can be used to emit
   // pc-descriptor information.
   intptr_t EmitInstanceCall(ExternalLabel* target_label,
                             const ICData& ic_data,
                             const Array& arguments_descriptor,
                             intptr_t argument_count);
 
   void EmitLoadIndexedGeneric(LoadIndexedComp* comp);
-
-  void EmitComment(Instruction* instr);
-
-  void EmitClassChecksNoSmi(const ICData& ic_data,
-                            Register instance_reg,
-                            Register temp_reg,
-                            Label* deopt);
   void EmitTestAndCall(const ICData& ic_data,
                        Register class_id_reg,
                        intptr_t arg_count,
                        const Array& arg_names,
                        Label* deopt,
                        Label* done,
                        intptr_t cid,
                        intptr_t token_index,
                        intptr_t try_index);
 
@@ skipping 18 matching lines @@
                       Register reg1 = kNoRegister,
                       Register reg2 = kNoRegister,
                       Register reg3 = kNoRegister);
 
   void FinalizeExceptionHandlers(const Code& code);
   void FinalizePcDescriptors(const Code& code);
   void FinalizeStackmaps(const Code& code);
   void FinalizeVarDescriptors(const Code& code);
   void FinalizeComments(const Code& code);
 
+  const Bool& bool_true() const { return bool_true_; }
+  const Bool& bool_false() const { return bool_false_; }
+  const Class& double_class() const { return double_class_; }
+
   FrameRegisterAllocator* frame_register_allocator() {
     return &frame_register_allocator_;
   }
 
   static const int kLocalsOffsetFromFP = (-1 * kWordSize);
 
-  const Bool& bool_true() const { return bool_true_; }
-  const Bool& bool_false() const { return bool_false_; }
-  const Class& double_class() const { return double_class_; }
-
  private:
   friend class DeoptimizationStub;
 
   void GenerateDeferredCode();
 
-  void CopyParameters();
   void EmitInstructionPrologue(Instruction* instr);
 
-  void GenerateInlinedGetter(intptr_t offset);
-  void GenerateInlinedSetter(intptr_t offset);
+  // Emit code to load a Value into register 'dst'.
+  void LoadValue(Register dst, Value* value);
+
+  // Returns pc-offset (in bytes) of the pc after the call, can be used to emit
+  // pc-descriptor information.
+  intptr_t EmitStaticCall(const Function& function,
+                          const Array& arguments_descriptor,
+                          intptr_t argument_count);
+
+  // Type checking helper methods.
+  void CheckClassIds(Register class_id_reg,
+                     const GrowableArray<intptr_t>& class_ids,
+                     Label* is_instance_lbl,
+                     Label* is_not_instance_lbl);
 
   RawSubtypeTestCache* GenerateInlineInstanceof(intptr_t cid,
                                                 intptr_t token_pos,
                                                 const AbstractType& type,
                                                 Label* is_instance_lbl,
                                                 Label* is_not_instance_lbl);
 
   RawSubtypeTestCache* GenerateInstantiatedTypeWithArgumentsTest(
       intptr_t cid,
       intptr_t token_pos,
@@ skipping 29 matching lines @@
 
   RawSubtypeTestCache* GenerateCallSubtypeTestStub(TypeTestStubKind test_kind,
                                                    Register instance_reg,
                                                    Register type_arguments_reg,
                                                    Register temp_reg,
                                                    Label* is_instance_lbl,
                                                    Label* is_not_instance_lbl);
 
   void GenerateBoolToJump(Register bool_reg, Label* is_true, Label* is_false);
 
-  void CheckClassIds(Register class_id_reg,
-                     const GrowableArray<intptr_t>& class_ids,
-                     Label* is_equal_lbl,
-                     Label* is_not_equal_lbl);
+  void CopyParameters();
 
+  void GenerateInlinedGetter(intptr_t offset);
+  void GenerateInlinedSetter(intptr_t offset);
 
   // Map a block number in a forward iteration into the block number in the
   // corresponding reverse iteration.  Used to obtain an index into
   // block_order for reverse iterations.
   intptr_t reverse_index(intptr_t index) const {
     return block_order_.length() - index - 1;
   }
 
   class Assembler* assembler_;
   const ParsedFunction& parsed_function_;
@@ skipping 43 matching lines @@
   const intptr_t deopt_id_;
   const intptr_t deopt_token_pos_;
   const intptr_t try_index_;
   const DeoptReasonId reason_;
   GrowableArray<Register> registers_;
   Label entry_label_;
 
   DISALLOW_COPY_AND_ASSIGN(DeoptimizationStub);
 };
 
-
 }  // namespace dart
 
 #endif  // VM_FLOW_GRAPH_COMPILER_IA32_H_