Issue 10636027: Support proper propagation of enabled per context and at runtime attributes.

Issue 10636027: Support proper propagation of enabled per context and at runtime attributes. (Closed)

Created:
8 years, 6 months ago by Anton Muhin

Modified:
8 years, 6 months ago

Reviewers:
podivilov

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Support proper propagation of enabled per context and at runtime attributes. And support enabled per context in native generator. R=podivilov@chromium.org Committed: https://code.google.com/p/dart/source/detail?r=9072

Patch Set 1 #

Total comments: 1

Patch Set 2 : Next iteration #

Total comments: 2

Patch Set 3 : Last iteration #

Created: 8 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+56 lines, -7 lines)			Patch
M	lib/dom/scripts/databasebuilder.py	View	1 2	1 chunk	+25 lines, -0 lines	0 comments	Download
M	lib/dom/scripts/fremontcutbuilder.py	View		1 chunk	+1 line, -0 lines	0 comments	Download
M	lib/dom/scripts/systemnative.py	View	1 2	2 chunks	+30 lines, -7 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

podivilov

https://chromiumcodereview.appspot.com/10636027/diff/1/lib/dom/scripts/databasebuilder.py File lib/dom/scripts/databasebuilder.py (right): https://chromiumcodereview.appspot.com/10636027/diff/1/lib/dom/scripts/databasebuilder.py#newcode565 lib/dom/scripts/databasebuilder.py:565: def fetch_constructor_data(self, options): Could you please move this logic ...

8 years, 6 months ago (2012-06-25 14:06:42 UTC) #2

podivilov

lgtm https://chromiumcodereview.appspot.com/10636027/diff/4001/lib/dom/scripts/systemnative.py File lib/dom/scripts/systemnative.py (right): https://chromiumcodereview.appspot.com/10636027/diff/4001/lib/dom/scripts/systemnative.py#newcode316 lib/dom/scripts/systemnative.py:316: FEATURE=self._interface.ext_attrs['V8EnabledPerContext']) shouldn't that be synthesized-*?

8 years, 6 months ago (2012-06-25 17:44:42 UTC) #4

Anton Muhin

8 years, 6 months ago (2012-06-25 17:46:41 UTC) #5

https://chromiumcodereview.appspot.com/10636027/diff/4001/lib/dom/scripts/sys...
File lib/dom/scripts/systemnative.py (right):

https://chromiumcodereview.appspot.com/10636027/diff/4001/lib/dom/scripts/sys...
lib/dom/scripts/systemnative.py:316:
FEATURE=self._interface.ext_attrs['V8EnabledPerContext'])
Thanks!  Done.

On 2012/06/25 17:44:42, podivilov wrote:
> shouldn't that be synthesized-*?

Expand Messages | Collapse Messages