Support proper propagation of enabled per context and at runtime attributes.

lib/dom/scripts/systemnative.py

 #!/usr/bin/python
 # Copyright (c) 2012, the Dart project authors.  Please see the AUTHORS file
 # for details. All rights reserved. Use of this source code is governed by a
 # BSD-style license that can be found in the LICENSE file.
 
 """This module provides shared functionality for the systems to generate
 native binding from the IDL database."""
 
 import emitter
 import os
@@ skipping 284 matching lines @@
 
     # Process constructor arguments.
     for (i, argument) in enumerate(constructor_info.idl_args):
       argument_expression = self._GenerateToNative(
           parameter_definitions_emitter, argument, i)
       arguments.append(argument_expression)
 
     function_expression = '%s::%s' % (self._interface_type_info.native_type(), create_function)
     invocation = self._GenerateWebCoreInvocation(function_expression, arguments,
         self._interface.id, self._interface.ext_attrs, raises_dom_exceptions)
+
+    runtime_check = None
+    database = self._system._database
+    if 'synthesized-V8EnabledPerContext' in self._interface.ext_attrs:
+      raises_exceptions = True
+      self._cpp_impl_includes.add('"ContextFeatures.h"')
+      runtime_check = emitter.Format(
+          '        if (ContextFeatures::$(FEATURE)Enabled(DartUtilities::domWindowForCurrentIsolate()->document())) {\n'
+          '            exception = Dart_NewString("Feature $FEATURE is not enabled");\n'
+          '            goto fail;\n'
+          '        }',
+          FEATURE=self._interface.ext_attrs['V8EnabledPerContext'])

[podivilov, 2012/06/25 17:44:42]

shouldn't that be synthesized-*?

[Anton Muhin, 2012/06/25 17:46:41]

Thanks!  Done.

On 2012/06/25 17:44:42, podivilov wrote:

+
     self._GenerateNativeCallback(callback_name='constructorCallback',
         parameter_definitions=parameter_definitions_emitter.Fragments(),
         needs_receiver=False, invocation=invocation,
-        raises_exceptions=raises_exceptions)
+        raises_exceptions=raises_exceptions,
+        runtime_check=runtime_check)
 
   def _EmitHtmlElementFactoryConstructors(self, infos, html_interface_name):
     EmitHtmlElementFactoryConstructors(
         self._system._EmitterForFactoryProviderBody(
             infos[0].factory_provider_name),
         infos,
         html_interface_name,
         html_interface_name)
 
   def _GenerateEvents(self):
@@ skipping 574 matching lines @@
 
     function_expression = self._GenerateWebCoreFunctionExpression(webcore_function_name, operation)
     invocation = self._GenerateWebCoreInvocation(function_expression, cpp_arguments,
         operation.type.id, operation.ext_attrs, operation.raises)
     self._GenerateNativeCallback(cpp_callback_name,
         parameter_definitions=parameter_definitions_emitter.Fragments(),
         needs_receiver=not operation.is_static, invocation=invocation,
         raises_exceptions=raises_exceptions)
 
   def _GenerateNativeCallback(self, callback_name, parameter_definitions,
-      needs_receiver, invocation, raises_exceptions):
+      needs_receiver, invocation, raises_exceptions, runtime_check=None):
+
+    head = parameter_definitions
 
     if needs_receiver:
-      parameter_definitions = emitter.Format(
+      head = emitter.Format(
           '        $WEBCORE_CLASS_NAME* receiver = DartDOMWrapper::receiver< $WEBCORE_CLASS_NAME >(args);\n'
-          '        $PARAMETER_DEFINITIONS\n',
+          '$HEAD\n',
           WEBCORE_CLASS_NAME=self._interface_type_info.native_type(),
-          PARAMETER_DEFINITIONS=parameter_definitions)
+          HEAD=head)
+
+    if runtime_check:
+      head = emitter.Format(
+          '$RUNTIME_CHECK\n'
+          '$HEAD\n',
+          RUNTIME_CHECK=runtime_check,
+          HEAD=head)
 
     body = emitter.Format(
         '    {\n'
-        '$PARAMETER_DEFINITIONS'
+        '$HEAD'
         '$INVOCATION'
         '        return;\n'
         '    }\n',
-        PARAMETER_DEFINITIONS=parameter_definitions,
+        HEAD=head,
         INVOCATION=invocation)
 
     if raises_exceptions:
       body = emitter.Format(
           '    Dart_Handle exception = 0;\n'
           '$BODY'
           '\n'
           'fail:\n'
           '    Dart_ThrowException(exception);\n'
           '    ASSERT_NOT_REACHED();\n',
@@ skipping 120 matching lines @@
       continue
     parent_interface = database.GetInterface(parent.type.id)
     if callback(parent_interface):
       return parent_interface
     parent_interface = _FindParent(parent_interface, database, callback)
     if parent_interface:
       return parent_interface
 
 def _IsArgumentOptionalInWebCore(argument):
   return IsOptional(argument) and not 'Callback' in argument.ext_attrs