Issue 10603004: Fix bug in inlined Math.sqrt.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10603004: Fix bug in inlined Math.sqrt. (Closed)

Created:
8 years, 6 months ago by srdjan

Modified:
8 years, 6 months ago

Reviewers:
siva

CC:
reviews_dartlang.org, vm-dev_dartlang.org, regis

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

More Reviews

Description

Fix bug in inlined Math.sqrt. Committed: https://code.google.com/p/dart/source/detail?r=8958

Patch Set 1 #

Total comments: 2

Created: 8 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+2 lines, -3 lines)			Patch
M	runtime/vm/assembler_macros_x64.cc	View	1 chunk	+0 lines, -3 lines	0 comments	Download
M	runtime/vm/flow_graph_compiler_ia32.cc	View	1 chunk	+1 line, -0 lines	1 comment	Download
M	runtime/vm/flow_graph_compiler_x64.cc	View	1 chunk	+1 line, -0 lines	1 comment	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

siva

8 years, 6 months ago (2012-06-21 00:39:59 UTC) #2

lgtm

https://chromiumcodereview.appspot.com/10603004/diff/1/runtime/vm/flow_graph_...
File runtime/vm/flow_graph_compiler_ia32.cc (right):

https://chromiumcodereview.appspot.com/10603004/diff/1/runtime/vm/flow_graph_...
runtime/vm/flow_graph_compiler_ia32.cc:89: __ Drop(1);
Could you add a comment here explaining that the argument was on stack and needs
to be popped when the fast case succeeds.

https://chromiumcodereview.appspot.com/10603004/diff/1/runtime/vm/flow_graph_...
File runtime/vm/flow_graph_compiler_x64.cc (right):

https://chromiumcodereview.appspot.com/10603004/diff/1/runtime/vm/flow_graph_...
runtime/vm/flow_graph_compiler_x64.cc:898: __ Drop(1);
Ditto.

Expand Messages | Collapse Messages