Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(50)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: runtime/vm/flow_graph_compiler_ia32.cc

Issue 10603004: Fix bug in inlined Math.sqrt. (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: Created 8 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « runtime/vm/assembler_macros_x64.cc ('k') | runtime/vm/flow_graph_compiler_x64.cc » ('j') | runtime/vm/flow_graph_compiler_x64.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/vm/flow_graph_compiler_ia32.cc
===================================================================
--- runtime/vm/flow_graph_compiler_ia32.cc (revision 8951)
+++ runtime/vm/flow_graph_compiler_ia32.cc (working copy)
@@ -86,6 +86,7 @@
&call_method,
EAX); // Result register.
__ movsd(FieldAddress(EAX, Double::value_offset()), XMM0);
+ __ Drop(1);
siva 2012/06/21 00:39:59 Could you add a comment here explaining that the a
__ jmp(done);
__ Bind(&smi_to_double);
__ SmiUntag(EAX);
« no previous file with comments | « runtime/vm/assembler_macros_x64.cc ('k') | runtime/vm/flow_graph_compiler_x64.cc » ('j') | runtime/vm/flow_graph_compiler_x64.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698