Issue 10592023: - Fix the barrier code when low bits of Smi are zeroes.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10592023: - Fix the barrier code when low bits of Smi are zeroes. (Closed)

Created:
8 years, 6 months ago by Ivan Posva

Modified:
8 years, 6 months ago

Reviewers:
siva, cshapiro

CC:
reviews_dartlang.org

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

More Reviews

Description

- Fix the barrier code when low bits of Smi are zeroes. - Harden the assembler test for StoreIntoObject to test a variety of Smi values. Committed: https://code.google.com/p/dart/source/detail?r=8939

Patch Set 1 #

Total comments: 1

Created: 8 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+11 lines, -7 lines)			Patch
	M	runtime/vm/assembler_ia32.cc	View		1 chunk	+1 line, -0 lines	0 comments	Download
	M	runtime/vm/assembler_ia32_test.cc	View		2 chunks	+10 lines, -7 lines	1 comment	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Ivan Posva

Thanks to Carl for finding the missing condition. -Ivan

8 years, 6 months ago (2012-06-20 20:20:10 UTC) #1

cshapiro

lgtm https://chromiumcodereview.appspot.com/10592023/diff/1/runtime/vm/assembler_ia32_test.cc File runtime/vm/assembler_ia32_test.cc (right): https://chromiumcodereview.appspot.com/10592023/diff/1/runtime/vm/assembler_ia32_test.cc#newcode1878 runtime/vm/assembler_ia32_test.cc:1878: for (int i = -32; i < 32; ...

8 years, 6 months ago (2012-06-20 20:36:11 UTC) #2

lgtm

Expand Messages | Collapse Messages