Issue 10584044: Check that the C string passed to Dart_NewString is valid UTF-8.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10584044: Check that the C string passed to Dart_NewString is valid UTF-8. (Closed)

Created:
8 years, 6 months ago by cshapiro

Modified:
8 years, 6 months ago

Reviewers:
hausner

CC:
reviews_dartlang.org, vm-dev_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Check that the C string passed to Dart_NewString is valid UTF-8. BUG=2663 Committed: https://code.google.com/p/dart/source/detail?r=8942

Patch Set 2 : #

Total comments: 2

Created: 8 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+65 lines, -0 lines)			Patch
M	runtime/vm/dart_api_impl.cc	View	1 chunk	+8 lines, -0 lines	2 comments	Download
M	runtime/vm/dart_api_impl_test.cc	View	1 chunk	+21 lines, -0 lines	0 comments	Download
M	runtime/vm/unicode.h	View	1 chunk	+2 lines, -0 lines	0 comments	Download
M	runtime/vm/unicode.cc	View	2 chunks	+34 lines, -0 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

hausner

LGTM w/comment http://codereview.chromium.org/10584044/diff/2001/runtime/vm/dart_api_impl.cc File runtime/vm/dart_api_impl.cc (right): http://codereview.chromium.org/10584044/diff/2001/runtime/vm/dart_api_impl.cc#newcode1503 runtime/vm/dart_api_impl.cc:1503: return Api::NewError("%s expects argument 'str' to be ...

8 years, 6 months ago (2012-06-20 22:05:25 UTC) #2

cshapiro

8 years, 6 months ago (2012-06-20 22:09:06 UTC) #3

http://codereview.chromium.org/10584044/diff/2001/runtime/vm/dart_api_impl.cc
File runtime/vm/dart_api_impl.cc (right):

http://codereview.chromium.org/10584044/diff/2001/runtime/vm/dart_api_impl.cc...
runtime/vm/dart_api_impl.cc:1503: return Api::NewError("%s expects argument
'str' to be non-null.",
This turns out to be part of the debugger API.  I will move this around in a
separate change so the rest of this file can make use of that definition.

Expand Messages | Collapse Messages

Issue 10584044: Check that the C string passed to Dart_NewString is valid UTF-8. (Closed)

Description

Patch Set 1 #

Patch Set 2 : #

Messages