Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(111)

Issue 10583034: Add setup of JAVA_HOME to the annotated steps script. The buildbot will pass the relative path to t… (Closed)

Created:
8 years, 6 months ago by ricow1
Modified:
8 years, 6 months ago
Reviewers:
ahe, zundel
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Add setup of JAVA_HOME to the annotated steps script. The buildbot will pass the relative path to this through an environment variable. Committed: https://code.google.com/p/dart/source/detail?r=8910

Patch Set 1 #

Patch Set 2 : Changed to base the setting on BUILDBOT_JAVA_HOME #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -0 lines) Patch
M client/tools/buildbot_annotated_steps.py View 1 2 chunks +13 lines, -0 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
ricow1
8 years, 6 months ago (2012-06-20 14:26:20 UTC) #1
zundel
lgtm
8 years, 6 months ago (2012-06-20 14:41:21 UTC) #2
ahe
8 years, 6 months ago (2012-06-22 09:57:02 UTC) #3
LGTM!

Powered by Google App Engine
This is Rietveld 408576698