Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(573)

Unified Diff: client/tools/buildbot_annotated_steps.py

Issue 10583034: Add setup of JAVA_HOME to the annotated steps script. The buildbot will pass the relative path to t… (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: Changed to base the setting on BUILDBOT_JAVA_HOME Created 8 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: client/tools/buildbot_annotated_steps.py
===================================================================
--- client/tools/buildbot_annotated_steps.py (revision 8837)
+++ client/tools/buildbot_annotated_steps.py (working copy)
@@ -129,6 +129,16 @@
os.path.join('utils', 'compiler', 'buildbot.py')],
env=os.environ, shell=has_shell)
+def FixJavaHome():
+ buildbot_javahome = os.getenv('BUILDBOT_JAVA_HOME')
+ if buildbot_javahome:
+ current_pwd = os.getenv('PWD')
+ java_home = os.path.join(current_pwd, buildbot_javahome)
+ os.environ['JAVA_HOME'] = java_home
+ print 'Setting java home to'
+ print java_home
+
+
def main():
print 'main'
if len(sys.argv) == 0:
@@ -141,6 +151,9 @@
#TODO(sigmund): remove this indirection once we update our bots
(name, version) = GetBuildInfo()
+ # The buildbot will set a BUILDBOT_JAVA_HOME relative to the dart
+ # root directory, set JAVA_HOME based on that.
+ FixJavaHome()
if name.startswith('dart-editor'):
status = ProcessTools('release', name, version)
else:
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698