Issue 10581049: - Implement the filtering store barrier on x64.

Issue 10581049: - Implement the filtering store barrier on x64. (Closed)

Created:
8 years, 6 months ago by Ivan Posva

Modified:
8 years, 6 months ago

Reviewers:
cshapiro, siva, srdjan

CC:
reviews_dartlang.org, srdjan

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

More Reviews

Description

- Implement the filtering store barrier on x64. Committed: https://code.google.com/p/dart/source/detail?r=8953

Patch Set 1 #

Total comments: 8

Created: 8 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+112 lines, -22 lines)			Patch
M	runtime/vm/assembler_ia32.h	View	1 chunk	+2 lines, -0 lines	0 comments	Download
M	runtime/vm/assembler_ia32.cc	View	2 chunks	+18 lines, -14 lines	0 comments	Download
M	runtime/vm/assembler_x64.h	View	2 chunks	+9 lines, -0 lines	2 comments	Download
M	runtime/vm/assembler_x64.cc	View	1 chunk	+38 lines, -1 line	0 comments	Download
M	runtime/vm/stub_code_ia32.cc	View	3 chunks	+1 line, -2 lines	0 comments	Download
M	runtime/vm/stub_code_x64.cc	View	2 chunks	+44 lines, -5 lines	6 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

srdjan

LGTM with comments/questions https://chromiumcodereview.appspot.com/10581049/diff/1/runtime/vm/stub_code_x64.cc File runtime/vm/stub_code_x64.cc (right): https://chromiumcodereview.appspot.com/10581049/diff/1/runtime/vm/stub_code_x64.cc#newcode1081 runtime/vm/stub_code_x64.cc:1081: // Load top_ out of the ...

8 years, 6 months ago (2012-06-20 23:28:27 UTC) #2

siva

lgtm with comment and the 'q' comments which Srdjan has indicated. https://chromiumcodereview.appspot.com/10581049/diff/1/runtime/vm/assembler_x64.h File runtime/vm/assembler_x64.h (right): ...

8 years, 6 months ago (2012-06-20 23:33:28 UTC) #3

Ivan Posva

8 years, 6 months ago (2012-06-20 23:48:01 UTC) #4

Thanks.

-Ivan

https://chromiumcodereview.appspot.com/10581049/diff/1/runtime/vm/assembler_x...
File runtime/vm/assembler_x64.h (right):

https://chromiumcodereview.appspot.com/10581049/diff/1/runtime/vm/assembler_x...
runtime/vm/assembler_x64.h:525: const Object& value);
On 2012/06/20 23:33:28, asiva wrote:
> This method doesn't seem to be implemented in the 64 bit case.

I am waiting for a use of this and then we can implement it with a particular
test case in hand.

https://chromiumcodereview.appspot.com/10581049/diff/1/runtime/vm/stub_code_x...
File runtime/vm/stub_code_x64.cc (right):

https://chromiumcodereview.appspot.com/10581049/diff/1/runtime/vm/stub_code_x...
runtime/vm/stub_code_x64.cc:1085: __ movl(RBX,
On 2012/06/20 23:28:27, srdjan wrote:
> movq?

top_ in StoreBufferBlock is an int32_t. I had these as q and it failed.

Expand Messages | Collapse Messages