- Implement the filtering store barrier on x64.

runtime/vm/stub_code_x64.cc

 // Copyright (c) 2012, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 #include "vm/globals.h"
 #if defined(TARGET_ARCH_X64)
 
 #include "vm/assembler.h"
 #include "vm/assembler_macros.h"
 #include "vm/code_generator.h"
@@ skipping 639 matching lines @@
     // R13: Points to new space object.
     __ movq(Address(R13, Scavenger::top_offset()), R12);
     __ addq(RAX, Immediate(kHeapObjectTag));
 
     // RAX: new object start as a tagged pointer.
     // R12: new object end address.
     // RBX: array element type.
     // R10: Array length as Smi.
 
     // Store the type argument field.
-    __ StoreIntoObject(RAX,
-                       FieldAddress(RAX, Array::type_arguments_offset()),
-                       RBX);
+    __ StoreIntoObjectNoBarrier(
+        RAX, FieldAddress(RAX, Array::type_arguments_offset()), RBX);
 
     // Set the length field.
-    __ StoreIntoObject(RAX, FieldAddress(RAX, Array::length_offset()), R10);
+    __ StoreIntoObjectNoBarrier(
+        RAX, FieldAddress(RAX, Array::length_offset()), R10);
 
     // Calculate the size tag.
     // RAX: new object start as a tagged pointer.
     // R12: new object end address.
     // R10: Array length as Smi.
     {
       Label size_tag_overflow, done;
       __ leaq(RBX, Address(R10, TIMES_4, fixed_size));  // R10 is Smi.
       ASSERT(kSmiTagShift == 1);
       __ andq(RBX, Immediate(-kObjectAlignment));
@@ skipping 385 matching lines @@
   __ popq(RAX);  // Pop the new context object.
   // RAX: new object
   // Restore the frame pointer.
   __ LeaveFrame();
   __ ret();
 }
 
 
 // Helper stub to implement Assembler::StoreIntoObject.
 // Input parameters:
+//   RAX: Address being stored
 void StubCode::GenerateUpdateStoreBufferStub(Assembler* assembler) {
-  __ Unimplemented("StubCode::GenerateUpdateStoreBufferStub");
+  // Save registers being destroyed.
+  __ pushq(CTX);
+  __ pushq(RBX);
+
+  // Load the isolate out of the context.
+  // RAX: Address being stored
+  __ movq(CTX, FieldAddress(CTX, Context::isolate_offset()));
+
+  // Load top_ out of the StoreBufferBlock and add teh address to the pointers_.

[srdjan, 2012/06/20 23:28:27]

s/teh/the/

+  // RAX: Address being stored
+  // CTX: Isolate
+  intptr_t store_buffer_offset = Isolate::store_buffer_offset();
+  __ movl(RBX,

[srdjan, 2012/06/20 23:28:27]

movq?

[Ivan Posva, 2012/06/20 23:48:01]

top_ in StoreBufferBlock is an int32_t. I had these as q and it failed.

+          Address(CTX, store_buffer_offset + StoreBufferBlock::top_offset()));
+  __ movq(Address(CTX,
+                  RBX, TIMES_4,
+                  store_buffer_offset + StoreBufferBlock::pointers_offset()),
+          RAX);
+
+  // Increment top_ and check for overflow.
+  // RBX: top_
+  // CTX: Isolate
+  Label L;
+  __ incq(RBX);
+  __ movl(Address(CTX, store_buffer_offset + StoreBufferBlock::top_offset()),
+          RBX);

[srdjan, 2012/06/20 23:28:27]

movq?

+  __ cmpl(RBX, Immediate(StoreBufferBlock::kSize));

[srdjan, 2012/06/20 23:28:27]

cmpq?

+  __ j(NOT_EQUAL, &L, Assembler::kNearJump);
+
+  // Handle overflow: Reset the top_ pointer.
+  // CTX: Isolate
+  __ movl(RBX, Immediate(0));
+  __ movl(Address(CTX, store_buffer_offset + StoreBufferBlock::top_offset()),

[srdjan, 2012/06/20 23:28:27]

movq (both).

+          RBX);
+
+  __ Bind(&L);
+  // Restore values.
+  __ popq(RBX);
+  __ popq(CTX);
   __ ret();
 }
 
 
 // Called for inline allocation of objects.
 // Input parameters:
 //   RSP + 16 : type arguments object (only if class is parameterized).
 //   RSP + 8 : type arguments of instantiator (only if class is parameterized).
 //   RSP : points to return address.
 void StubCode::GenerateAllocationStubForClass(Assembler* assembler,
@@ skipping 747 matching lines @@
 // TOS + 2: instance.
 // TOS + 3: cache array.
 // Result in RCX: null -> not found, otherwise result (true or false).
 void StubCode::GenerateSubtype3TestCacheStub(Assembler* assembler) {
   GenerateSubtypeNTestCacheStub(assembler, 3);
 }
 
 }  // namespace dart
 
 #endif  // defined TARGET_ARCH_X64