Issue 10578046: - Inline the store buffer update into a stub instead of

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10578046: - Inline the store buffer update into a stub instead of (Closed)

Created:
8 years, 6 months ago by Ivan Posva

Modified:
8 years, 6 months ago

Reviewers:
siva

CC:
reviews_dartlang.org

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

More Reviews

Description

- Inline the store buffer update into a stub instead of calling out into the C++ runtime. Committed: https://code.google.com/p/dart/source/detail?r=8929

Patch Set 3 : #

Created: 8 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+149 lines, -10 lines)			Patch
M	runtime/vm/assembler_ia32.cc	View		2 chunks	+4 lines, -10 lines	0 comments	Download
M	runtime/vm/assembler_ia32_test.cc	View	1 2	1 chunk	+74 lines, -0 lines	0 comments	Download
M	runtime/vm/isolate.h	View		1 chunk	+3 lines, -0 lines	0 comments	Download
M	runtime/vm/store_buffer.h	View		1 chunk	+2 lines, -0 lines	0 comments	Download
M	runtime/vm/store_buffer.cc	View		1 chunk	+10 lines, -0 lines	0 comments	Download
M	runtime/vm/stub_code.h	View		1 chunk	+1 line, -0 lines	0 comments	Download
M	runtime/vm/stub_code_ia32.cc	View		1 chunk	+47 lines, -0 lines	0 comments	Download
M	runtime/vm/stub_code_x64.cc	View	1	1 chunk	+8 lines, -0 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

siva

lgtm https://chromiumcodereview.appspot.com/10578046/diff/9001/runtime/vm/assembler_ia32_test.cc File runtime/vm/assembler_ia32_test.cc (right): https://chromiumcodereview.appspot.com/10578046/diff/9001/runtime/vm/assembler_ia32_test.cc#newcode1890 runtime/vm/assembler_ia32_test.cc:1890: GrowableObjectArray::data_offset() - kHeapObjectTag)); Should we also have a ...

8 years, 6 months ago (2012-06-20 17:57:28 UTC) #2

Ivan Posva

8 years, 6 months ago (2012-06-20 18:05:36 UTC) #3

Thanks.

-Ivan

https://chromiumcodereview.appspot.com/10578046/diff/9001/runtime/vm/assemble...
File runtime/vm/assembler_ia32_test.cc (right):

https://chromiumcodereview.appspot.com/10578046/diff/9001/runtime/vm/assemble...
runtime/vm/assembler_ia32_test.cc:1890: GrowableObjectArray::data_offset() -
kHeapObjectTag));
On 2012/06/20 17:57:28, asiva wrote:
> Should we also have a test for:
> // Store a new object into a new object.
> to ensure that no store buffer updates are done for that.

Done.

Expand Messages | Collapse Messages

Issue 10578046: - Inline the store buffer update into a stub instead of (Closed)

Description

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Messages