Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(410)

Unified Diff: runtime/vm/assembler_ia32.cc

Issue 10578046: - Inline the store buffer update into a stub instead of (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: Created 8 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | runtime/vm/assembler_ia32_test.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/vm/assembler_ia32.cc
===================================================================
--- runtime/vm/assembler_ia32.cc (revision 8921)
+++ runtime/vm/assembler_ia32.cc (working copy)
@@ -13,8 +13,6 @@
namespace dart {
-DECLARE_RUNTIME_ENTRY(StoreBuffer);
-
DEFINE_FLAG(bool, print_stop_message, true, "Print stop message.");
DEFINE_FLAG(bool, code_comments, false,
"Include comments into code and disassembly");
@@ -1400,14 +1398,10 @@
testl(object, Immediate(kNewObjectAlignmentOffset));
j(NOT_ZERO, &done, Assembler::kNearJump);
// A store buffer update is required.
- pushal();
- movl(EBP, ESP);
- ReserveAlignedFrameSpace(kWordSize);
- movl(EAX, dest);
- movl(Address(ESP, 0), EAX); // Push argument
- CallRuntime(kStoreBufferRuntimeEntry);
- movl(ESP, EBP);
- popal();
+ pushl(EAX); // Preserve EAX.
+ leal(EAX, dest);
+ call(&StubCode::UpdateStoreBufferLabel());
+ popl(EAX); // Restore EAX.
Bind(&done);
}
« no previous file with comments | « no previous file | runtime/vm/assembler_ia32_test.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698