Issue 10574015: Fix a bug in type assertions involving String supertypes.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10574015: Fix a bug in type assertions involving String supertypes. (Closed)

Created:
8 years, 6 months ago by ahe

Modified:
8 years, 6 months ago

Reviewers:
kasperl

CC:
reviews_dartlang.org, ngeoffray

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

More Reviews

Description

Fix a bug in type assertions involving String supertypes. Committed: https://code.google.com/p/dart/source/detail?r=8837

Patch Set 2 : Address review comments #

Created: 8 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+28 lines, -0 lines)			Patch
	M	dart/lib/compiler/implementation/ssa/codegen.dart	View		1 chunk	+1 line, -0 lines	0 comments	Download
	A	dart/tests/language/string_supertype_checked_test.dart	View	1	1 chunk	+27 lines, -0 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

kasperl

LGTM. Thanks for fixing this, Peter! https://chromiumcodereview.appspot.com/10574015/diff/1/dart/tests/language/string_supertype_checked_test.dart File dart/tests/language/string_supertype_checked_test.dart (right): https://chromiumcodereview.appspot.com/10574015/diff/1/dart/tests/language/string_supertype_checked_test.dart#newcode26 dart/tests/language/string_supertype_checked_test.dart:26: print("a.compareTo(b) == ${a.compareTo(b)}"); ...

8 years, 6 months ago (2012-06-19 10:28:11 UTC) #2

ahe

8 years, 6 months ago (2012-06-19 10:47:19 UTC) #3

Thank you for taking a look, Kasper!

https://chromiumcodereview.appspot.com/10574015/diff/1/dart/tests/language/st...
File dart/tests/language/string_supertype_checked_test.dart (right):

https://chromiumcodereview.appspot.com/10574015/diff/1/dart/tests/language/st...
dart/tests/language/string_supertype_checked_test.dart:26: print("a.compareTo(b)
== ${a.compareTo(b)}");
On 2012/06/19 10:28:11, kasperl wrote:
> I'd prefer it if this actually checked the result of calling compareTo.

Done.

Expand Messages | Collapse Messages

Issue 10574015: Fix a bug in type assertions involving String supertypes. (Closed)

Description

Patch Set 1 #

Patch Set 2 : Address review comments #

Messages