Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(581)

Unified Diff: dart/lib/compiler/implementation/ssa/codegen.dart

Issue 10574015: Fix a bug in type assertions involving String supertypes. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge
Patch Set: Address review comments Created 8 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | dart/tests/language/string_supertype_checked_test.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: dart/lib/compiler/implementation/ssa/codegen.dart
diff --git a/dart/lib/compiler/implementation/ssa/codegen.dart b/dart/lib/compiler/implementation/ssa/codegen.dart
index 446650771825bda19d4374ec396891120b1b03fd..258a85b6aca743042f8034e0757249a61b46567b 100644
--- a/dart/lib/compiler/implementation/ssa/codegen.dart
+++ b/dart/lib/compiler/implementation/ssa/codegen.dart
@@ -2444,6 +2444,7 @@ class SsaCodeGenerator implements HVisitor, HBlockInformationVisitor {
} else if (element == compiler.intClass) {
helper = const SourceString('intTypeCheck');
} else if (Elements.isStringSupertype(element, compiler)) {
+ additionalArgument = compiler.namer.operatorIs(element);
if (nativeCheck) {
helper = const SourceString('stringSuperNativeTypeCheck');
} else {
« no previous file with comments | « no previous file | dart/tests/language/string_supertype_checked_test.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698