Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(951)

Issue 10562020: Clean up DartAstUtilities.getElement(), analysis should provide element for every identifier (Closed)

Created:
8 years, 6 months ago by scheglov
Modified:
8 years, 6 months ago
Reviewers:
Brian Wilkerson
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Clean up DartAstUtilities.getElement(), analysis should provide element for every identifier R=brianwilkerson@google.com BUG= TEST= Committed: https://code.google.com/p/dart/source/detail?r=8757

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+52 lines, -87 lines) Patch
M compiler/java/com/google/dart/compiler/type/TypeAnalyzer.java View 1 chunk +5 lines, -1 line 0 comments Download
M editor/tools/plugins/com.google.dart.tools.core/src/com/google/dart/tools/core/utilities/ast/DartAstUtilities.java View 2 chunks +0 lines, -86 lines 0 comments Download
M editor/tools/plugins/com.google.dart.tools.core_test/src/com/google/dart/tools/core/utilities/ast/DartElementLocatorTest.java View 2 chunks +47 lines, -0 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
scheglov
8 years, 6 months ago (2012-06-15 22:28:48 UTC) #1
Brian Wilkerson
8 years, 6 months ago (2012-06-15 23:34:49 UTC) #2
LGTM

Powered by Google App Engine
This is Rietveld 408576698