compiler/java/com/google/dart/compiler/type/TypeAnalyzer.java - Issue 10562020: Clean up DartAstUtilities.getElement(), analysis should provide element for every identifier

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: compiler/java/com/google/dart/compiler/type/TypeAnalyzer.java

Issue 10562020: Clean up DartAstUtilities.getElement(), analysis should provide element for every identifier (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: Created 8 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « no previous file | editor/tools/plugins/com.google.dart.tools.core/src/com/google/dart/tools/core/utilities/ast/DartAstUtilities.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: compiler/java/com/google/dart/compiler/type/TypeAnalyzer.java

diff --git a/compiler/java/com/google/dart/compiler/type/TypeAnalyzer.java b/compiler/java/com/google/dart/compiler/type/TypeAnalyzer.java

index 5e110bf054ba4083cab6bbcdab02797104325356..4698468cd3fa5b368d2dd70d60ef7211a0e307eb 100644

--- a/compiler/java/com/google/dart/compiler/type/TypeAnalyzer.java

+++ b/compiler/java/com/google/dart/compiler/type/TypeAnalyzer.java

@@ -1146,7 +1146,11 @@ public class TypeAnalyzer implements DartCompilationPhase {

List<DartExpression> arguments = node.getArguments();

Member member = lookupMember(receiver, name, node.getFunctionName());

if (member != null) {

- node.setElement(member.getElement());

+ Element methodElement = member.getElement();

+ node.setElement(methodElement);

+ if (node.getFunctionName() != null) {

+ node.getFunctionName().setElement(methodElement);

+ }

}

return analyzeMethodInvocation(receiver, member, name,

node.getFunctionName(), analyzeArgumentTypes(arguments),