Issue 10562013: Issue 3643. Changes for review comments

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10562013: Issue 3643. Changes for review comments (Closed)

Created:
8 years, 6 months ago by scheglov

Modified:
8 years, 6 months ago

Reviewers:
Brian Wilkerson

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

Created: 8 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+11 lines, -11 lines)			Patch
M	compiler/java/com/google/dart/compiler/ast/DartIdentifier.java	View	3 chunks	+6 lines, -6 lines	0 comments	Download
M	compiler/java/com/google/dart/compiler/resolver/Resolver.java	View	2 chunks	+3 lines, -3 lines	0 comments	Download
M	compiler/java/com/google/dart/compiler/type/TypeAnalyzer.java	View	1 chunk	+1 line, -1 line	0 comments	Download
M	compiler/javatests/com/google/dart/compiler/type/TypeAnalyzerCompilerTest.java	View	1 chunk	+1 line, -1 line	0 comments	Download

Total messages: 2 (0 generated)

Brian Wilkerson

8 years, 6 months ago (2012-06-15 19:15:28 UTC) #2

I was kind of hoping you could come up with a better name than I did :-), but
LGTM.