Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(27)

Unified Diff: compiler/java/com/google/dart/compiler/resolver/Resolver.java

Issue 10562013: Issue 3643. Changes for review comments (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 8 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: compiler/java/com/google/dart/compiler/resolver/Resolver.java
diff --git a/compiler/java/com/google/dart/compiler/resolver/Resolver.java b/compiler/java/com/google/dart/compiler/resolver/Resolver.java
index 6b9ffaacaa77b47620e4c9f303a096fd5b4671d7..c2dc5ac5801446f873fd7960e82b140a898476a1 100644
--- a/compiler/java/com/google/dart/compiler/resolver/Resolver.java
+++ b/compiler/java/com/google/dart/compiler/resolver/Resolver.java
@@ -1209,7 +1209,7 @@ public class Resolver {
element = member.getElement();
// Must be accessible.
if (!Elements.isAccessible(context.getScope().getLibrary(), element)) {
- name.markResolutionError();
+ name.markResolutionAlreadyReportedThatTheMethodCouldNotBeFound();
onError(name, ResolverErrorCode.CANNOT_ACCESS_METHOD, x.getFunctionNameString());
}
}
@@ -1482,11 +1482,11 @@ public class Resolver {
switch (kind) {
case NONE:
if (isStaticContextOrInitializer()) {
- node.getTarget().markResolutionError();
+ node.getTarget().markResolutionAlreadyReportedThatTheMethodCouldNotBeFound();
onError(node.getTarget(), ResolverErrorCode.CANNOT_RESOLVE_METHOD, name);
}
if (scope.findElement(null, name) != null) {
- node.getTarget().markResolutionError();
+ node.getTarget().markResolutionAlreadyReportedThatTheMethodCouldNotBeFound();
onError(node.getTarget(), ResolverErrorCode.CANNOT_ACCESS_METHOD, name);
}
break;

Powered by Google App Engine
This is Rietveld 408576698