Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(21)

Issue 10560032: Reapply "Don't try to resolve in the builder". (Closed)

Created:
8 years, 6 months ago by floitsch
Modified:
8 years, 6 months ago
Reviewers:
ahe
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Reapply "Don't try to resolve in the builder". This commits a fixed version of r8777. Original review url: https://chromiumcodereview.appspot.com//10559031 Committed: https://code.google.com/p/dart/source/detail?r=8787

Patch Set 1 #

Patch Set 2 : Add test. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+25 lines, -2 lines) Patch
M lib/compiler/implementation/ssa/builder.dart View 1 chunk +3 lines, -1 line 0 comments Download
M tests/compiler/dart2js/compiler_helper.dart View 1 chunk +1 line, -1 line 0 comments Download
A tests/language/resolution_test.dart View 1 1 chunk +21 lines, -0 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
floitsch
TBR.
8 years, 6 months ago (2012-06-18 13:04:36 UTC) #1
ahe
8 years, 6 months ago (2012-06-18 13:09:52 UTC) #2
LGTM!

Powered by Google App Engine
This is Rietveld 408576698