Issue 10559031: Don't try to resolve in the builder.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10559031: Don't try to resolve in the builder. (Closed)

Created:
8 years, 6 months ago by floitsch

Modified:
8 years, 6 months ago

Reviewers:
ahe

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Don't try to resolve in the builder. Resolution is already done. Fixes issue 3632. Committed: https://code.google.com/p/dart/source/detail?r=8777

Patch Set 2 : Address comment. #

Created: 8 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+24 lines, -1 line)			Patch
	M	lib/compiler/implementation/ssa/builder.dart	View	1	1 chunk	+3 lines, -1 line	0 comments	Download
	A	tests/language/resolution_test.dart	View		1 chunk	+21 lines, -0 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

ahe

LGTM! https://chromiumcodereview.appspot.com/10559031/diff/1/lib/compiler/implementation/ssa/builder.dart File lib/compiler/implementation/ssa/builder.dart (right): https://chromiumcodereview.appspot.com/10559031/diff/1/lib/compiler/implementation/ssa/builder.dart#newcode2358 lib/compiler/implementation/ssa/builder.dart:2358: assert(compiler.enqueuer.resolution.getCachedElements(element) !== null); I would prefer if this ...

8 years, 6 months ago (2012-06-18 09:50:06 UTC) #2

floitsch

8 years, 6 months ago (2012-06-18 10:30:21 UTC) #3

https://chromiumcodereview.appspot.com/10559031/diff/1/lib/compiler/implement...
File lib/compiler/implementation/ssa/builder.dart (right):

https://chromiumcodereview.appspot.com/10559031/diff/1/lib/compiler/implement...
lib/compiler/implementation/ssa/builder.dart:2358:
assert(compiler.enqueuer.resolution.getCachedElements(element) !== null);
On 2012/06/18 09:50:07, ahe wrote:
> I would prefer if this was an internal error:
> 
> if (compiler.enqueuer.resolution.getCachedElements(element) === null) {
>   compiler.internalError('Unresolved element: $element', node: node);
> }

Done.

Expand Messages | Collapse Messages

Issue 10559031: Don't try to resolve in the builder. (Closed)

Description

Patch Set 1 #

Patch Set 2 : Address comment. #

Messages