Issue 10557003: Fix most warnings and other minor cleanups.

Issue 10557003: Fix most warnings and other minor cleanups. (Closed)

Created:
8 years, 6 months ago by floitsch

Modified:
8 years, 6 months ago

Reviewers:
karlklose

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Fix most warnings and other minor cleanups. Committed: https://code.google.com/p/dart/source/detail?r=8719

Patch Set 2 : Address comments. #

Patch Set 3 : rebase. #

Created: 8 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+141 lines, -129 lines)			Patch
M	lib/compiler/implementation/compiler.dart	View		6 chunks	+9 lines, -6 lines	0 comments	Download
M	lib/compiler/implementation/dart_backend/backend.dart	View		1 chunk	+4 lines, -1 line	0 comments	Download
M	lib/compiler/implementation/namer.dart	View		2 chunks	+23 lines, -25 lines	0 comments	Download
M	lib/compiler/implementation/native_handler.dart	View		1 chunk	+1 line, -1 line	0 comments	Download
M	lib/compiler/implementation/operations.dart	View		1 chunk	+1 line, -2 lines	0 comments	Download
M	lib/compiler/implementation/resolver.dart	View		1 chunk	+16 lines, -17 lines	0 comments	Download
M	lib/compiler/implementation/scanner/scanner_bench.dart	View		1 chunk	+2 lines, -2 lines	0 comments	Download
M	lib/compiler/implementation/scanner/scanner_task.dart	View		1 chunk	+1 line, -1 line	0 comments	Download
M	lib/compiler/implementation/ssa/builder.dart	View	1	8 chunks	+20 lines, -23 lines	0 comments	Download
M	lib/compiler/implementation/ssa/codegen.dart	View	1 2	3 chunks	+12 lines, -9 lines	0 comments	Download
M	lib/compiler/implementation/ssa/tracer.dart	View	1 2	2 chunks	+49 lines, -36 lines	0 comments	Download
M	lib/compiler/implementation/tree/nodes.dart	View		1 chunk	+3 lines, -6 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

karlklose

LGTM with comments. https://chromiumcodereview.appspot.com/10557003/diff/1/lib/compiler/implementation/resolver.dart File lib/compiler/implementation/resolver.dart (right): https://chromiumcodereview.appspot.com/10557003/diff/1/lib/compiler/implementation/resolver.dart#newcode54 lib/compiler/implementation/resolver.dart:54: if (kind === ElementKind.GENERATIVE_CONSTRUCTOR || Break ...

8 years, 6 months ago (2012-06-15 12:43:46 UTC) #2

floitsch

8 years, 6 months ago (2012-06-15 13:05:17 UTC) #3

Unfortunately left most of it as is.

https://chromiumcodereview.appspot.com/10557003/diff/1/lib/compiler/implement...
File lib/compiler/implementation/ssa/builder.dart (right):

https://chromiumcodereview.appspot.com/10557003/diff/1/lib/compiler/implement...
lib/compiler/implementation/ssa/builder.dart:914: FunctionSignature params =
constructor.computeSignature(compiler);
On 2012/06/15 12:43:46, karlklose wrote:
> I would prefer the name parameters.

Renamed to "signature".

https://chromiumcodereview.appspot.com/10557003/diff/1/lib/compiler/implement...
File lib/compiler/implementation/ssa/tracer.dart (right):

https://chromiumcodereview.appspot.com/10557003/diff/1/lib/compiler/implement...
lib/compiler/implementation/ssa/tracer.dart:168: if (type ==
HType.MUTABLE_ARRAY) {
On 2012/06/15 12:43:46, karlklose wrote:
> How about a map?

literal maps must contain strings as keys.

Expand Messages | Collapse Messages