Issue 3531. Don't allow using built-in identifier as import prefix

Issue 3531. Don't allow using built-in identifier as import prefix
http://code.google.com/p/dart/issues/detail?id=3531

And couple other built-in/reserved issues.


R=brianwilkerson@google.com
BUG=
TEST=

Committed: https://code.google.com/p/dart/source/detail?r=8558

[Brian Wilkerson, 2012-06-12 15:20:02]

After a few minor changes, LGTM.

https://chromiumcodereview.appspot.com/10545131/diff/1/compiler/java/com/goog...
File compiler/java/com/google/dart/compiler/parser/DartParser.java (right):

https://chromiumcodereview.appspot.com/10545131/diff/1/compiler/java/com/goog...
compiler/java/com/google/dart/compiler/parser/DartParser.java:180: "false",
Missing "final".

https://chromiumcodereview.appspot.com/10545131/diff/1/compiler/java/com/goog...
File compiler/java/com/google/dart/compiler/resolver/TopLevelElementBuilder.java
(right):

https://chromiumcodereview.appspot.com/10545131/diff/1/compiler/java/com/goog...
compiler/java/com/google/dart/compiler/resolver/TopLevelElementBuilder.java:70: 
nit: trailing whitespace

https://chromiumcodereview.appspot.com/10545131/diff/1/compiler/javatests/com...
File compiler/javatests/com/google/dart/compiler/parser/NegativeParserTest.java
(right):

https://chromiumcodereview.appspot.com/10545131/diff/1/compiler/javatests/com...
compiler/javatests/com/google/dart/compiler/parser/NegativeParserTest.java:787: 
nit: trailing whitespace

https://chromiumcodereview.appspot.com/10545131/diff/1/compiler/javatests/com...
compiler/javatests/com/google/dart/compiler/parser/NegativeParserTest.java:842:
"interface assert {}",
Missing "as".

https://chromiumcodereview.appspot.com/10545131/diff/1/compiler/javatests/com...
compiler/javatests/com/google/dart/compiler/parser/NegativeParserTest.java:844:
"interface equals {}",
"equals" is not a built-in identifier according to the spec.

https://chromiumcodereview.appspot.com/10545131/diff/1/compiler/javatests/com...
File
compiler/javatests/com/google/dart/compiler/type/TypeAnalyzerCompilerTest.java
(right):

https://chromiumcodereview.appspot.com/10545131/diff/1/compiler/javatests/com...
compiler/javatests/com/google/dart/compiler/type/TypeAnalyzerCompilerTest.java:2136:
"  assert     v02;",
Missing "as"; remove "equals" (or ensure that it's valid).

https://chromiumcodereview.appspot.com/10545131/diff/1/tests/language/pseudo_...
File tests/language/pseudo_kw_illegal_test.dart (right):

https://chromiumcodereview.appspot.com/10545131/diff/1/tests/language/pseudo_...
tests/language/pseudo_kw_illegal_test.dart:8: class assert { }      /// 02:
compile-time error
Missing "as".

https://chromiumcodereview.appspot.com/10545131/diff/1/tests/language/pseudo_...
tests/language/pseudo_kw_illegal_test.dart:13: class import { }      /// 08:
compile-time error
Remove "import", "library", and "source".

[scheglov, 2012-06-12 18:04:22]

https://chromiumcodereview.appspot.com/10545131/diff/1/compiler/java/com/goog...
File compiler/java/com/google/dart/compiler/parser/DartParser.java (right):

https://chromiumcodereview.appspot.com/10545131/diff/1/compiler/java/com/goog...
compiler/java/com/google/dart/compiler/parser/DartParser.java:180: "false",
On 2012/06/12 15:20:02, Brian Wilkerson wrote:
> Missing "final".

Done.

https://chromiumcodereview.appspot.com/10545131/diff/1/compiler/java/com/goog...
File compiler/java/com/google/dart/compiler/resolver/TopLevelElementBuilder.java
(right):

https://chromiumcodereview.appspot.com/10545131/diff/1/compiler/java/com/goog...
compiler/java/com/google/dart/compiler/resolver/TopLevelElementBuilder.java:70: 
On 2012/06/12 15:20:02, Brian Wilkerson wrote:
> nit: trailing whitespace

Done.

https://chromiumcodereview.appspot.com/10545131/diff/1/compiler/javatests/com...
File compiler/javatests/com/google/dart/compiler/parser/NegativeParserTest.java
(right):

https://chromiumcodereview.appspot.com/10545131/diff/1/compiler/javatests/com...
compiler/javatests/com/google/dart/compiler/parser/NegativeParserTest.java:787: 
On 2012/06/12 15:20:02, Brian Wilkerson wrote:
> nit: trailing whitespace

Done.

https://chromiumcodereview.appspot.com/10545131/diff/1/compiler/javatests/com...
compiler/javatests/com/google/dart/compiler/parser/NegativeParserTest.java:842:
"interface assert {}",
On 2012/06/12 15:20:02, Brian Wilkerson wrote:
> Missing "as".

"as" can not be used because "as" is not identifier, it is operator token.
But we check for it in prefix (as requested in this issue), because this is
string literal.

https://chromiumcodereview.appspot.com/10545131/diff/1/compiler/javatests/com...
compiler/javatests/com/google/dart/compiler/parser/NegativeParserTest.java:844:
"interface equals {}",
On 2012/06/12 15:20:02, Brian Wilkerson wrote:
> "equals" is not a built-in identifier according to the spec.

Hm... In recent released spec, "equals" is built-in identifier.
And in co19 too.
So, I will keep it there for now.

[Brian Wilkerson, 2012-06-12 18:22:29]

https://chromiumcodereview.appspot.com/10545131/diff/1/compiler/javatests/com...
File compiler/javatests/com/google/dart/compiler/parser/NegativeParserTest.java
(right):

https://chromiumcodereview.appspot.com/10545131/diff/1/compiler/javatests/com...
compiler/javatests/com/google/dart/compiler/parser/NegativeParserTest.java:842:
"interface assert {}",
> "as" can not be used because "as" is not identifier, it is operator token.
> But we check for it in prefix (as requested in this issue), because this is
> string literal.

OK. In the spec it is listed in the production "BUILT_IN_IDENTIFIER", so the
distinction wasn't obvious.