compiler/java/com/google/dart/compiler/resolver/TopLevelElementBuilder.java - Issue 10545131: Issue 3531. Don't allow using built-in identifier as import prefix

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: compiler/java/com/google/dart/compiler/resolver/TopLevelElementBuilder.java

Issue 10545131: Issue 3531. Don't allow using built-in identifier as import prefix (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: Tweaks for review comments Created 8 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « compiler/java/com/google/dart/compiler/resolver/ResolverErrorCode.java ('k') | compiler/javatests/com/google/dart/compiler/end2end/inc/IncrementalCompilation2Test.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: compiler/java/com/google/dart/compiler/resolver/TopLevelElementBuilder.java

diff --git a/compiler/java/com/google/dart/compiler/resolver/TopLevelElementBuilder.java b/compiler/java/com/google/dart/compiler/resolver/TopLevelElementBuilder.java

index 07abae93c7bc0f9659ce7f98e092a570ae91b643..681e61800f1f492e5e75e974fb32dbc528a3828a 100644

--- a/compiler/java/com/google/dart/compiler/resolver/TopLevelElementBuilder.java

+++ b/compiler/java/com/google/dart/compiler/resolver/TopLevelElementBuilder.java

@@ -16,13 +16,17 @@ import com.google.dart.compiler.ast.DartField;

import com.google.dart.compiler.ast.DartFieldDefinition;

import com.google.dart.compiler.ast.DartFunctionTypeAlias;

import com.google.dart.compiler.ast.DartIdentifier;

+import com.google.dart.compiler.ast.DartImportDirective;

import com.google.dart.compiler.ast.DartMethodDefinition;

import com.google.dart.compiler.ast.DartNode;

+import com.google.dart.compiler.ast.DartStringLiteral;

import com.google.dart.compiler.ast.DartTypeParameter;

import com.google.dart.compiler.ast.DartUnit;

+import com.google.dart.compiler.ast.LibraryNode;

import com.google.dart.compiler.ast.LibraryUnit;

import com.google.dart.compiler.ast.Modifiers;

import com.google.dart.compiler.common.SourceInfo;

+import com.google.dart.compiler.parser.DartParser;

import com.google.dart.compiler.type.Type;

import com.google.dart.compiler.type.TypeVariable;

import com.google.dart.compiler.type.Types;