Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1)

Issue 10543111: Optimize StoreIndexedComp on ia32&x64. (Closed)

Created:
8 years, 6 months ago by Vyacheslav Egorov (Google)
Modified:
8 years, 6 months ago
Reviewers:
srdjan
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Optimize StoreIndexedComp on ia32&x64. R=srdjan@google.com BUG= TEST= Committed: https://code.google.com/p/dart/source/detail?r=8595

Patch Set 1 #

Patch Set 2 : disable store indexed specialization if FLAG_enable_type_checks #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+221 lines, -37 lines) Patch
M runtime/vm/flow_graph_compiler.cc View 1 chunk +3 lines, -1 line 1 comment Download
M runtime/vm/flow_graph_compiler_ia32.h View 1 chunk +2 lines, -1 line 1 comment Download
M runtime/vm/flow_graph_compiler_x64.h View 1 chunk +2 lines, -1 line 0 comments Download
M runtime/vm/flow_graph_optimizer.h View 1 chunk +1 line, -0 lines 0 comments Download
M runtime/vm/flow_graph_optimizer.cc View 1 1 chunk +31 lines, -6 lines 0 comments Download
M runtime/vm/intermediate_language.h View 2 chunks +11 lines, -1 line 0 comments Download
M runtime/vm/intermediate_language_ia32.cc View 2 chunks +82 lines, -11 lines 0 comments Download
M runtime/vm/intermediate_language_x64.cc View 4 chunks +89 lines, -16 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Vyacheslav Egorov (Google)
8 years, 6 months ago (2012-06-12 13:14:35 UTC) #1
srdjan
https://chromiumcodereview.appspot.com/10543111/diff/3001/runtime/vm/flow_graph_compiler.cc File runtime/vm/flow_graph_compiler.cc (right): https://chromiumcodereview.appspot.com/10543111/diff/3001/runtime/vm/flow_graph_compiler.cc#newcode161 runtime/vm/flow_graph_compiler.cc:161: stub->Push(reg1); I think we need to guard reg2 as ...
8 years, 6 months ago (2012-06-12 16:43:46 UTC) #2
srdjan
8 years, 6 months ago (2012-06-12 16:43:52 UTC) #3
lgtm

Powered by Google App Engine
This is Rietveld 408576698