Issue 10542167: Inline Math.sqrt in new compilers.

Issue 10542167: Inline Math.sqrt in new compilers. (Closed)

Created:
8 years, 6 months ago by regis

Modified:
8 years, 6 months ago

Reviewers:
srdjan

CC:
reviews_dartlang.org, Vyacheslav Egorov (Google), Florian Schneider

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

More Reviews

Description

Inline Math.sqrt in new compilers. Committed: https://code.google.com/p/dart/source/detail?r=8702

Patch Set 4 : #

Created: 8 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+176 lines, -86 lines)			Patch
M	runtime/vm/assembler_x64.h	View	1 2 3	1 chunk	+2 lines, -0 lines	0 comments	Download
M	runtime/vm/assembler_x64.cc	View	1 2 3	1 chunk	+11 lines, -0 lines	0 comments	Download
M	runtime/vm/assembler_x64_test.cc	View	1 2 3	2 chunks	+18 lines, -3 lines	0 comments	Download
M	runtime/vm/flow_graph_compiler.cc	View	1 2 3	2 chunks	+4 lines, -1 line	0 comments	Download
M	runtime/vm/flow_graph_compiler_ia32.h	View	1 2 3	3 chunks	+4 lines, -0 lines	0 comments	Download
M	runtime/vm/flow_graph_compiler_ia32.cc	View	1 2 3	1 chunk	+24 lines, -0 lines	0 comments	Download
M	runtime/vm/flow_graph_compiler_x64.h	View	1 2 3	3 chunks	+4 lines, -0 lines	0 comments	Download
M	runtime/vm/flow_graph_compiler_x64.cc	View	1 2 3	1 chunk	+24 lines, -0 lines	0 comments	Download
M	runtime/vm/flow_graph_optimizer.cc	View	1 2 3	2 chunks	+1 line, -59 lines	0 comments	Download
M	runtime/vm/intermediate_language.h	View	1 2 3	4 chunks	+34 lines, -1 line	0 comments	Download
M	runtime/vm/intermediate_language.cc	View	1 2 3	3 chunks	+43 lines, -1 line	0 comments	Download
M	runtime/vm/intermediate_language_ia32.cc	View	1 2 3	3 chunks	+3 lines, -10 lines	0 comments	Download
M	runtime/vm/intermediate_language_x64.cc	View	1 2 3	3 chunks	+3 lines, -10 lines	0 comments	Download
M	runtime/vm/opt_code_generator_ia32.cc	View	1 2 3	1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

srdjan

LGTM https://chromiumcodereview.appspot.com/10542167/diff/1/runtime/vm/flow_graph_compiler_ia32.cc File runtime/vm/flow_graph_compiler_ia32.cc (right): https://chromiumcodereview.appspot.com/10542167/diff/1/runtime/vm/flow_graph_compiler_ia32.cc#newcode75 runtime/vm/flow_graph_compiler_ia32.cc:75: // if the argument is double, smi or ...

8 years, 6 months ago (2012-06-14 23:30:08 UTC) #2

regis

8 years, 6 months ago (2012-06-15 00:33:58 UTC) #3

Thanks!

https://chromiumcodereview.appspot.com/10542167/diff/1/runtime/vm/flow_graph_...
File runtime/vm/flow_graph_compiler_ia32.cc (right):

https://chromiumcodereview.appspot.com/10542167/diff/1/runtime/vm/flow_graph_...
runtime/vm/flow_graph_compiler_ia32.cc:75: // if the argument is double, smi or
something else.
On 2012/06/14 23:30:08, srdjan wrote:
> Math.sqrt is a static method, we do not collect types for static methods. 

Removed TODO.

https://chromiumcodereview.appspot.com/10542167/diff/1/runtime/vm/flow_graph_...
runtime/vm/flow_graph_compiler_ia32.cc:85: // TODO(regis): Should we cache
double_class in FlowGraphCompiler instance?
On 2012/06/14 23:30:08, srdjan wrote:
> Yes, there are also similar TODO's  for vegorov.

Done.

https://chromiumcodereview.appspot.com/10542167/diff/1/runtime/vm/flow_graph_...
runtime/vm/flow_graph_compiler_ia32.cc:94: __ Bind(&smi_to_double);
On 2012/06/14 23:30:08, srdjan wrote:
> Add comment: Smi to Double calls static method?
> Why don't you convert the Smi to double and jump to done ?

Done.

https://chromiumcodereview.appspot.com/10542167/diff/1/runtime/vm/intermediat...
File runtime/vm/intermediate_language.cc (right):

https://chromiumcodereview.appspot.com/10542167/diff/1/runtime/vm/intermediat...
runtime/vm/intermediate_language.cc:1046:
compiler->GenerateInlinedMathSqrt(&done);
On 2012/06/14 23:30:08, srdjan wrote:
> Add comment that it fall throughs to static call.

Done.

Expand Messages | Collapse Messages