Inline Math.sqrt in new compilers.

runtime/vm/flow_graph_compiler_ia32.cc

 // Copyright (c) 2012, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 #include "vm/globals.h"  // Needed here to get TARGET_ARCH_IA32.
 #if defined(TARGET_ARCH_IA32)
 
 #include "vm/flow_graph_compiler.h"
 
 #include "lib/error.h"
@@ skipping 53 matching lines @@
   __ movl(EAX, Address(ESP, 2 * kWordSize));  // Receiver.
   __ movl(EBX, Address(ESP, 1 * kWordSize));  // Value.
   __ StoreIntoObject(EAX, FieldAddress(EAX, offset), EBX);
   const Immediate raw_null =
       Immediate(reinterpret_cast<intptr_t>(Object::null()));
   __ movl(EAX, raw_null);
   __ ret();
 }
 
 
+// TODO(srdjan): For Math.sqrt read type feedback in Math.sqrt and decide
+// if the argument is double, smi or something else.

[srdjan, 2012/06/14 23:30:08]

Math.sqrt is a static method, we do not collect types for static methods. 

[regis, 2012/06/15 00:33:59]

Removed TODO.

+void FlowGraphCompiler::GenerateInlinedMathSqrt(Label* done) {
+  Label smi_to_double, call_method;
+  __ movl(EAX, Address(ESP, 0));
+  __ testl(EAX, Immediate(kSmiTagMask));
+  __ j(ZERO, &smi_to_double, Assembler::kNearJump);
+  __ CompareClassId(EAX, kDouble, EBX);
+  __ j(NOT_EQUAL, &call_method, Assembler::kNearJump);
+  __ movsd(XMM1, FieldAddress(EAX, Double::value_offset()));
+  __ sqrtsd(XMM0, XMM1);
+  // TODO(regis): Should we cache double_class in FlowGraphCompiler instance?

[srdjan, 2012/06/14 23:30:08]

Yes, there are also similar TODO's  for vegorov.

[regis, 2012/06/15 00:33:59]

Done.

+  const Class& double_class =
+      Class::ZoneHandle(Isolate::Current()->object_store()->double_class());
+  AssemblerMacros::TryAllocate(assembler_,
+                               double_class,
+                               &call_method,
+                               EAX);  // Result register.
+  __ movsd(FieldAddress(EAX, Double::value_offset()), XMM0);
+  __ jmp(done);
+  __ Bind(&smi_to_double);

[srdjan, 2012/06/14 23:30:08]

Add comment: Smi to Double calls static method?
Why don't you convert the Smi to double and jump to done ?

[regis, 2012/06/15 00:33:59]

Done.

+  __ Bind(&call_method);
+}
+
+
 void FlowGraphCompiler::GenerateCallRuntime(intptr_t cid,
                                             intptr_t token_index,
                                             intptr_t try_index,
                                             const RuntimeEntry& entry) {
   __ CallRuntime(entry);
   AddCurrentDescriptor(PcDescriptors::kOther, cid, token_index, try_index);
 }
 
 
 void FlowGraphCompiler::CopyParameters() {
@@ skipping 922 matching lines @@
   __ cvtsi2sd(result, temp);
   __ Bind(&done);
 }
 
 
 #undef __
 
 }  // namespace dart
 
 #endif  // defined TARGET_ARCH_IA32