Issue 10539170: Fix DataView constructor and byte accessors.

Issue 10539170: Fix DataView constructor and byte accessors. (Closed)

Created:
8 years, 6 months ago by sra1

Modified:
8 years, 6 months ago

Reviewers:
vsm, Anton Muhin

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Fix DataView constructor and byte accessors. Custom constructor is not yet implemented for Dartium. Committed: https://code.google.com/p/dart/source/detail?r=8705

Patch Set 1 : #

Total comments: 7

Created: 8 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+192 lines, -35 lines)			Patch
M	lib/dom/dom.dart	View	4 chunks	+14 lines, -5 lines	0 comments	Download
M	lib/dom/frog/dom_frog.dart	View	6 chunks	+19 lines, -9 lines	0 comments	Download
M	lib/dom/idl/dart/dart.idl	View	1 chunk	+28 lines, -0 lines	2 comments	Download
M	lib/dom/scripts/generator.py	View	2 chunks	+2 lines, -2 lines	1 comment	Download
M	lib/dom/scripts/systemnative.py	View	1 chunk	+1 line, -1 line	0 comments	Download
A	lib/dom/templates/html/frog/factoryprovider_DataView.darttemplate	View	1 chunk	+13 lines, -0 lines	2 comments	Download
M	lib/html/dartium/html_dartium.dart	View	10 chunks	+19 lines, -9 lines	0 comments	Download
M	lib/html/frog/html_frog.dart	View	8 chunks	+24 lines, -9 lines	0 comments	Download
M	tests/html/html.status	View	2 chunks	+2 lines, -0 lines	1 comment	Download
A	tests/html/typed_arrays_dataview_test.dart	View	1 chunk	+70 lines, -0 lines	1 comment	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

sra1

Hi Vijay & Anton. I TBR-ed this because I was having problems with dartium_tools/test.py - ...

8 years, 6 months ago (2012-06-15 03:18:40 UTC) #1

vsm

lgtm https://chromiumcodereview.appspot.com/10539170/diff/1007/lib/dom/idl/dart/dart.idl File lib/dom/idl/dart/dart.idl (right): https://chromiumcodereview.appspot.com/10539170/diff/1007/lib/dom/idl/dart/dart.idl#newcode212 lib/dom/idl/dart/dart.idl:212: // We have to use custom code because ...

8 years, 6 months ago (2012-06-15 19:40:27 UTC) #2

Anton Muhin

8 years, 6 months ago (2012-06-18 10:25:35 UTC) #3

https://chromiumcodereview.appspot.com/10539170/diff/1007/lib/dom/scripts/gen...
File lib/dom/scripts/generator.py (left):

https://chromiumcodereview.appspot.com/10539170/diff/1007/lib/dom/scripts/gen...
lib/dom/scripts/generator.py:278: if 'CustomConstructor' in interface.ext_attrs:
apparently that will make _IntentFactoryProvider default implementation for
Intent, but I found no _IntentFactoryProvider in the sources.

https://chromiumcodereview.appspot.com/10539170/diff/1007/lib/dom/templates/h...
File lib/dom/templates/html/frog/factoryprovider_DataView.darttemplate (right):

https://chromiumcodereview.appspot.com/10539170/diff/1007/lib/dom/templates/h...
lib/dom/templates/html/frog/factoryprovider_DataView.darttemplate:7: [int
byteOffset = null, int byteLength = null])
why explicit null defaults?

https://chromiumcodereview.appspot.com/10539170/diff/1007/lib/dom/templates/h...
lib/dom/templates/html/frog/factoryprovider_DataView.darttemplate:9: if
(byteOffset == null) return new DataView(buffer);
nit: === instead of ==?

https://chromiumcodereview.appspot.com/10539170/diff/1007/tests/html/html.status
File tests/html/html.status (right):

https://chromiumcodereview.appspot.com/10539170/diff/1007/tests/html/html.sta...
tests/html/html.status:16: typed_arrays_dataview_test: Fail  # DataView
constructor not implemented.
why only in Debug mode?  And does it indeed pass in Release?

Expand Messages | Collapse Messages