Fix DataView constructor and byte accessors.

lib/dom/idl/dart/dart.idl

 
 // This file introduces / supplements and forces Dart declarations.
 
 module default {
   FileList implements sequence<File>;
   HTMLCollection implements sequence<Node>;
   MediaList implements sequence<DOMString>;
   NamedNodeMap implements sequence<Node>;
   NodeList implements sequence<Node>;
   StyleSheetList implements sequence<StyleSheet>;
@@ skipping 173 matching lines @@
   };
 
   [Supplemental]
   interface Uint8ClampedArray {
     // Avoid 'overriding static member BYTES_PER_ELEMENT'.
     [Suppressed] const long BYTES_PER_ELEMENT = 1;
 
     [Suppressed] void set();
     [DartName=setElements, Custom] void set(in any array, [Optional] in unsigned long offset);
   };
+
+  [Supplemental,
+   Constructor(in ArrayBuffer buffer,
+               [Optional] in unsigned long byteOffset,
+               [Optional] in unsigned long byteLength)
+   ]
+  interface DataView {
+    // Undo this:
+    // We have to use custom code because our code generator does not support int8_t type.
+    // int8_t getInt8(in unsigned long byteOffset);
+    // uint8_t getUint8(in unsigned long byteOffset);
+    [Suppressed] DOMObject getInt8();
+    [Suppressed] DOMObject getUint8();
+    byte getInt8(in unsigned long byteOffset)
+        raises (DOMException);
+    octet getUint8(in unsigned long byteOffset)
+        raises (DOMException);
+
+    // We have to use custom code because our code generator does not support uint8_t type.

[vsm, 2012/06/15 19:40:27]

nit: line length here and on 202.

+    // void setInt8(in unsigned long byteOffset, in int8_t value);
+    // void setUint8(in unsigned long byteOffset, in uint8_t value);

[vsm, 2012/06/15 19:40:27]

Is this just a matter of mapping int8_t/uint8_t to int in the generator.py
table?  I see you did that for byte.  Why not these?

Should there be any bounds checking?

+    [Suppressed] void setInt8();
+    [Suppressed] void setUint8();
+    void setInt8(in unsigned long byteOffset, in byte value)
+        raises (DOMException);
+    void setUint8(in unsigned long byteOffset, in octet value)
+        raises (DOMException);
+  };
 };
 
 module storage {
   // TODO(vsm): Define new names for these (see b/4436830).
   [Supplemental]
   interface IDBCursor {
     [DartName=continueFunction] void continue([Optional] in IDBKey key);
   };
   [Supplemental]
   interface IDBDatabase {
@@ skipping 27 matching lines @@
   [Supplemental, Callback] // Add missing Callback attribute.
   interface VoidCallback {
   };
 };
 
 module svg {
     interface SVGNumber {
       [StrictTypeChecking, Custom] attribute double value;
     };
 }