Reapply "Collect field getters and setters in the universe""

Reapply "Collect field getters and setters in the universe""

Added additional checks on the receiver instead of asserting that its
type was not null. HFieldSet and HFieldGet are used for other purposes
than instance fields.

R=ngeoffray@google.com

BUG=
TEST=

Committed: https://code.google.com/p/dart/source/detail?r=8534

[Søren Gjesse, 2012-06-12 07:59:30]

The difference between patch set #1 and #2 shows the changes to the original
patch.

[ngeoffray, 2012-06-12 08:23:07]

https://chromiumcodereview.appspot.com/10537118/diff/2001/lib/compiler/implem...
File lib/compiler/implementation/ssa/codegen.dart (right):

https://chromiumcodereview.appspot.com/10537118/diff/2001/lib/compiler/implem...
lib/compiler/implementation/ssa/codegen.dart:1691: if (node.receiver != null) {
I don't think this can happen, see line 1687

https://chromiumcodereview.appspot.com/10537118/diff/2001/lib/compiler/implem...
lib/compiler/implementation/ssa/codegen.dart:1693: if (type != null) {
I'm surprised that we have a null type here. A HInvokeDynamicGetter can only be
translated to HFieldGet if we know the type (see optimize.dart). So it looks
like a bug. Do you know what is causing a null type here?

[Søren Gjesse, 2012-06-12 10:09:17]

PTAL

https://chromiumcodereview.appspot.com/10537118/diff/2001/lib/compiler/implem...
File lib/compiler/implementation/ssa/codegen.dart (right):

https://chromiumcodereview.appspot.com/10537118/diff/2001/lib/compiler/implem...
lib/compiler/implementation/ssa/codegen.dart:1691: if (node.receiver != null) {
On 2012/06/12 08:23:07, ngeoffray wrote:
> I don't think this can happen, see line 1687

Removed check.

https://chromiumcodereview.appspot.com/10537118/diff/2001/lib/compiler/implem...
lib/compiler/implementation/ssa/codegen.dart:1693: if (type != null) {
On 2012/06/12 08:23:07, ngeoffray wrote:
> I'm surprised that we have a null type here. A HInvokeDynamicGetter can only
be
> translated to HFieldGet if we know the type (see optimize.dart). So it looks
> like a bug. Do you know what is causing a null type here?

As discussed offline there are HFieldGet instructions added by the builder not
translated from HInvokeDynamicGetter.

[ngeoffray, 2012-06-12 10:10:19]

LGTM!