Reapply "Collect field getters and setters in the universe""

lib/compiler/implementation/ssa/codegen.dart

 // Copyright (c) 2012, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 class SsaCodeGeneratorTask extends CompilerTask {
   final JavaScriptBackend backend;
   SsaCodeGeneratorTask(JavaScriptBackend backend)
       : this.backend = backend,
         super(backend.compiler);
   String get name() => 'SSA code generator';
@@ skipping 1301 matching lines @@
     }
   }
 
   visitTry(HTry node) {
     // We should never get here. Try/catch/finally is always handled using block
     // information in [visitTryInfo], or not at all, in the case of the bailout
     // generator.
     compiler.internalError('visitTry should not be called', instruction: node);
   }
 
-  /** 
+  /**
    * Analyzes the given [graph] to know whether it is empty, or
    * contains one statement, one expression, or multiple statements.
    */
   int analyzeGraphForCodegen(HStatementInformation graph) {
     HBasicBlock start = graph.start;
     HBasicBlock end = graph.end;
     // Only deal with single blocks for now. TODO(ngeoffray): analyze
     // all blocks.
     if (start !== end) return MULTIPLE_STATEMENTS;
-    
+
     int kind = EMPTY;
     bool updateKind(int newKind) {
       if (kind != EMPTY) return false;
       kind = newKind;
       return true;
     }
 
     for (HInstruction instruction = start.first;
          instruction != start.last;
          instruction = instruction.next) {
@@ skipping 338 matching lines @@
   }
 
   visitFieldGet(HFieldGet node) {
     if (!node.isFromActivation()) {
       String name = compiler.namer.getName(node.element);
       beginExpression(JSPrecedence.MEMBER_PRECEDENCE);
       use(node.receiver, JSPrecedence.MEMBER_PRECEDENCE);
       buffer.add('.');
       buffer.add(name);
       beginExpression(JSPrecedence.MEMBER_PRECEDENCE);
+      if (node.receiver != null) {

[ngeoffray, 2012/06/12 08:23:07]

I don't think this can happen, see line 1687

[Søren Gjesse, 2012/06/12 10:09:17]

Removed check.

+        Type type = node.receiver.propagatedType.computeType(compiler);
+        if (type != null) {

[ngeoffray, 2012/06/12 08:23:07]

I'm surprised that we have a null type here. A HInvokeDynamicGetter can only be
translated to HFieldGet if we know the type (see optimize.dart). So it looks
like a bug. Do you know what is causing a null type here?

[Søren Gjesse, 2012/06/12 10:09:17]

As discussed offline there are HFieldGet instructions added by the builder not
translated from HInvokeDynamicGetter.

+          world.registerFieldGetter(node.element.name, type);
+        }
+      }
     } else {
       use(node.receiver, JSPrecedence.EXPRESSION_PRECEDENCE);
     }
   }
 
   visitFieldSet(HFieldSet node) {
     String name;
     if (!node.isFromActivation()) {
       name = compiler.namer.getName(node.element);
       beginExpression(JSPrecedence.ASSIGNMENT_PRECEDENCE);
       use(node.receiver, JSPrecedence.MEMBER_PRECEDENCE);
       buffer.add('.');
       buffer.add(name);
+      if (node.receiver != null) {
+        Type type = node.receiver.propagatedType.computeType(compiler);
+        if (type != null) {
+          world.registerFieldSetter(node.element.name, type);
+        }
+      }
     } else {
       declareInstruction(node.receiver);
     }
     buffer.add(' = ');
     use(node.value, JSPrecedence.ASSIGNMENT_PRECEDENCE);
     if (node.receiver !== null) {
       endExpression(JSPrecedence.ASSIGNMENT_PRECEDENCE);
     }
   }
 
@@ skipping 902 matching lines @@
   bool visitAndOrInfo(HAndOrBlockInformation info) => false;
   bool visitIfInfo(HIfBlockInformation info) => false;
   bool visitLoopInfo(HLoopBlockInformation info) => false;
   bool visitTryInfo(HTryBlockInformation info) => false;
   bool visitSequenceInfo(HStatementSequenceInformation info) => false;
 
   // If argument is a [HCheck] and it does not have a name, we try to
   // find the name of its checked input. Note that there must be a
   // name, otherwise the instruction would not be in the live
   // environment.
-  HInstruction unwrap(argument) {       
+  HInstruction unwrap(argument) {
     while (argument is HCheck && !variableNames.hasName(argument)) {
       argument = argument.checkedInput;
     }
     assert(variableNames.hasName(argument));
-    return argument;    
+    return argument;
   }
 
   void visitTypeGuard(HTypeGuard node) {
     indent--;
     addIndented('case ${node.state}:\n');
     indent++;
     addIndented('state = 0;\n');
 
     setup.add('    case ${node.state}:\n');
     int i = 0;
@@ skipping 136 matching lines @@
       startBailoutSwitch();
     }
   }
 
   void endLabeledBlock(HLabeledBlockInformation labeledBlockInfo) {
     if (labeledBlockInfo.body.start.hasGuards()) {
       endBailoutSwitch();
     }
   }
 }