Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2)

Issue 10536203: Issue 2373. 'v is Unknown' is compile-time warning, not error (Closed)

Created:
8 years, 6 months ago by scheglov
Modified:
8 years, 6 months ago
Reviewers:
Brian Wilkerson
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Issue 2373. 'v is Unknown' is compile-time warning, not error http://code.google.com/p/dart/issues/detail?id=2373 ...but 'v is Known<No, Paramaters>' is error. Illogical, but so says the Spec. R=brianwilkerson@google.com BUG= TEST= Committed: https://code.google.com/p/dart/source/detail?r=8872

Patch Set 1 #

Total comments: 1

Messages

Total messages: 3 (0 generated)
scheglov
8 years, 6 months ago (2012-06-19 16:11:06 UTC) #1
Brian Wilkerson
LGTM, though you might want to hold off a little before committing to see whether ...
8 years, 6 months ago (2012-06-19 16:16:51 UTC) #2
scheglov
8 years, 6 months ago (2012-06-19 21:17:32 UTC) #3
> LGTM, though you might want to hold off a little before committing to see
> whether you get a response to your e-mail (in case the spec is wrong here).

I've got confirmation from Gilad that spec is correct.

-------
  So, using not existing type for check is OK (warning), but using existing type
incorrectly is error?

Yes.   I've explained why this is the case. 
-------

Powered by Google App Engine
This is Rietveld 408576698