Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(22)

Unified Diff: compiler/java/com/google/dart/compiler/resolver/MemberBuilder.java

Issue 10536203: Issue 2373. 'v is Unknown' is compile-time warning, not error (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 8 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: compiler/java/com/google/dart/compiler/resolver/MemberBuilder.java
diff --git a/compiler/java/com/google/dart/compiler/resolver/MemberBuilder.java b/compiler/java/com/google/dart/compiler/resolver/MemberBuilder.java
index 5e2f1faa8c40b7f8cceca4d32d904ac5b7d37a02..207370f8597bd51af8bb463c3d9b211da19f7144 100644
--- a/compiler/java/com/google/dart/compiler/resolver/MemberBuilder.java
+++ b/compiler/java/com/google/dart/compiler/resolver/MemberBuilder.java
@@ -169,7 +169,8 @@ public class MemberBuilder {
for (DartParameter parameter : node.getParameters()) {
parameters.add((VariableElement) parameter.accept(this));
}
- Type returnType = resolveType(node.getReturnTypeNode(), false, false, TypeErrorCode.NO_SUCH_TYPE);
+ Type returnType = resolveType(node.getReturnTypeNode(), false, false,
+ TypeErrorCode.NO_SUCH_TYPE, TypeErrorCode.WRONG_NUMBER_OF_TYPE_ARGUMENTS);
ClassElement functionElement = getTypeProvider().getFunctionType().getElement();
element.setFunctionType(Types.makeFunctionType(getContext(), functionElement,
parameters, returnType));
@@ -242,7 +243,8 @@ public class MemberBuilder {
isStatic = true;
}
}
- Type type = resolveType(node.getTypeNode(), isStatic, false, TypeErrorCode.NO_SUCH_TYPE);
+ Type type = resolveType(node.getTypeNode(), isStatic, false, TypeErrorCode.NO_SUCH_TYPE,
+ TypeErrorCode.WRONG_NUMBER_OF_TYPE_ARGUMENTS);
for (DartField fieldNode : node.getFields()) {
if (fieldNode.getModifiers().isAbstractField()) {
buildAbstractField(fieldNode);
@@ -284,7 +286,8 @@ public class MemberBuilder {
null,
true,
false,
- ResolverErrorCode.NO_SUCH_TYPE_CONSTRUCTOR).getElement();
+ ResolverErrorCode.NO_SUCH_TYPE_CONSTRUCTOR,
+ ResolverErrorCode.WRONG_NUMBER_OF_TYPE_ARGUMENTS).getElement();
}
@Override public Element visitParameterizedTypeNode(DartParameterizedTypeNode node) {
Element element = node.getExpression().accept(this);

Powered by Google App Engine
This is Rietveld 408576698