Issue 10536180: Issue 3530. Import elements into separate import namespace

Issue 10536180: Issue 3530. Import elements into separate import namespace (Closed)

Created:
8 years, 6 months ago by scheglov

Modified:
8 years, 6 months ago

Reviewers:
Brian Wilkerson

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Issue 3530. Import elements into separate import namespace http://code.google.com/p/dart/issues/detail?id=3530 R=brianwilkerson@google.com BUG= TEST= Committed: https://code.google.com/p/dart/source/detail?r=8696

Patch Set 1 #

Total comments: 3

Created: 8 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+78 lines, -74 lines)			Patch
M	compiler/java/com/google/dart/compiler/DartCompiler.java	View	4 chunks	+4 lines, -4 lines	0 comments	Download
M	compiler/java/com/google/dart/compiler/DeltaAnalyzer.java	View	3 chunks	+2 lines, -3 lines	1 comment	Download
M	compiler/java/com/google/dart/compiler/ast/LibraryUnit.java	View	6 chunks	+28 lines, -42 lines	0 comments	Download
M	compiler/java/com/google/dart/compiler/resolver/TopLevelElementBuilder.java	View	3 chunks	+5 lines, -8 lines	0 comments	Download
M	compiler/java/com/google/dart/compiler/resolver/TypeVariableElementImplementation.java	View	1 chunk	+2 lines, -1 line	1 comment	Download
M	compiler/javatests/com/google/dart/compiler/DeltaAnalyzerTest.java	View	1 chunk	+1 line, -1 line	1 comment	Download
M	compiler/javatests/com/google/dart/compiler/end2end/inc/IncrementalCompilation2Test.java	View	4 chunks	+21 lines, -5 lines	0 comments	Download
M	compiler/javatests/com/google/dart/compiler/type/TypeAnalyzerCompilerTest.java	View	1 chunk	+1 line, -1 line	0 comments	Download
M	editor/tools/plugins/com.google.dart.tools.core/src/com/google/dart/tools/core/internal/completion/CompletionEngine.java	View	1 chunk	+1 line, -1 line	0 comments	Download
M	editor/tools/plugins/com.google.dart.tools.core/src/com/google/dart/tools/core/internal/index/impl/InMemoryIndex.java	View	3 chunks	+6 lines, -4 lines	0 comments	Download
M	tests/co19/co19-compiler.status	View	2 chunks	+5 lines, -4 lines	0 comments	Download
M	tests/language/language.status	View	1 chunk	+2 lines, -0 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Brian Wilkerson

8 years, 6 months ago (2012-06-14 20:57:07 UTC) #2

LGTM

https://chromiumcodereview.appspot.com/10536180/diff/1/compiler/java/com/goog...
File compiler/java/com/google/dart/compiler/DeltaAnalyzer.java (right):

https://chromiumcodereview.appspot.com/10536180/diff/1/compiler/java/com/goog...
compiler/java/com/google/dart/compiler/DeltaAnalyzer.java:1: // Copyright (c)
2011, the Dart project authors.  Please see the AUTHORS file
nit: copyright year

https://chromiumcodereview.appspot.com/10536180/diff/1/compiler/java/com/goog...
File
compiler/java/com/google/dart/compiler/resolver/TypeVariableElementImplementation.java
(right):

https://chromiumcodereview.appspot.com/10536180/diff/1/compiler/java/com/goog...
compiler/java/com/google/dart/compiler/resolver/TypeVariableElementImplementation.java:1:
// Copyright (c) 2011, the Dart project authors.  Please see the AUTHORS file
nit: copyright year

https://chromiumcodereview.appspot.com/10536180/diff/1/compiler/javatests/com...
File compiler/javatests/com/google/dart/compiler/DeltaAnalyzerTest.java (right):

https://chromiumcodereview.appspot.com/10536180/diff/1/compiler/javatests/com...
compiler/javatests/com/google/dart/compiler/DeltaAnalyzerTest.java:1: //
Copyright (c) 2011, the Dart project authors.  Please see the AUTHORS file
nit: copyright year

Expand Messages | Collapse Messages