Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(453)

Unified Diff: compiler/javatests/com/google/dart/compiler/end2end/inc/IncrementalCompilation2Test.java

Issue 10536180: Issue 3530. Import elements into separate import namespace (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 8 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: compiler/javatests/com/google/dart/compiler/end2end/inc/IncrementalCompilation2Test.java
diff --git a/compiler/javatests/com/google/dart/compiler/end2end/inc/IncrementalCompilation2Test.java b/compiler/javatests/com/google/dart/compiler/end2end/inc/IncrementalCompilation2Test.java
index 3cfde87d5ccb728f02448e4bc5ad3742b547d158..7d8ab2cfec29849f3edd907bcc7f30fba9fe7cf2 100644
--- a/compiler/javatests/com/google/dart/compiler/end2end/inc/IncrementalCompilation2Test.java
+++ b/compiler/javatests/com/google/dart/compiler/end2end/inc/IncrementalCompilation2Test.java
@@ -24,6 +24,7 @@ import com.google.dart.compiler.SystemLibraryManager;
import com.google.dart.compiler.UrlSource;
import com.google.dart.compiler.ast.DartUnit;
import com.google.dart.compiler.ast.LibraryUnit;
+import com.google.dart.compiler.common.ErrorExpectation;
import com.google.dart.compiler.resolver.ResolverErrorCode;
import com.google.dart.compiler.resolver.TypeErrorCode;
@@ -782,7 +783,7 @@ public class IncrementalCompilation2Test extends CompilerTestCase {
compile();
assertErrors(errors, errEx(ResolverErrorCode.CANNOT_HIDE_IMPORT_PREFIX, 5, 7, 3));
}
-
+
/**
* <p>
* http://code.google.com/p/dart/issues/detail?id=3531
@@ -819,11 +820,25 @@ public class IncrementalCompilation2Test extends CompilerTestCase {
""));
// do compile, no errors expected
compile();
- assertEquals(14, errors.size());
- for (DartCompilationError error : errors) {
- assertEquals(ResolverErrorCode.BUILT_IN_IDENTIFIER_AS_IMPORT_PREFIX, error.getErrorCode());
+ {
+ assertEquals(14, errors.size());
+ for (DartCompilationError error : errors) {
+ assertEquals(ResolverErrorCode.BUILT_IN_IDENTIFIER_AS_IMPORT_PREFIX, error.getErrorCode());
+ }
}
}
+
+ public void test_implicitlyImportCore() throws Exception {
+ appSource.setContent(
+ APP,
+ makeCode(
+ "// filler filler filler filler filler filler filler filler filler filler filler",
+ "#library('application');",
+ "#import('dart:core');",
+ ""));
+ compile();
+ ErrorExpectation.assertErrors(errors);
+ }
private void assertAppBuilt() {
didWrite(APP, EXTENSION_DEPS);
@@ -848,7 +863,8 @@ public class IncrementalCompilation2Test extends CompilerTestCase {
@Override
public void onError(DartCompilationError event) {
// Remember errors only between unitAboutToCompile/unitCompiled.
- if (compilingUris.contains(event.getSource().getUri())) {
+ Source source = event.getSource();
+ if (source != null && compilingUris.contains(source.getUri())) {
errors.add(event);
}
}

Powered by Google App Engine
This is Rietveld 408576698