Issue 10536162: Add token kind into InstanceCallComp so that we do not need to extract it from name (addresses vego…

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10536162: Add token kind into InstanceCallComp so that we do not need to extract it from name (addresses vego… (Closed)

Created:
8 years, 6 months ago by srdjan

Modified:
8 years, 6 months ago

Reviewers:
Vyacheslav Egorov (Google)

CC:
reviews_dartlang.org, vm-dev_dartlang.org

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

More Reviews

Description

Add token kind into InstanceCallComp so that we do not need to extract it from name (addresses vego… Committed: https://code.google.com/p/dart/source/detail?r=8675

Patch Set 3 : #

Created: 8 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+45 lines, -50 lines)			Patch
M	runtime/vm/flow_graph_builder.cc	View	1	4 chunks	+9 lines, -7 lines	0 comments	Download
M	runtime/vm/flow_graph_optimizer.cc	View	1	1 chunk	+7 lines, -6 lines	0 comments	Download
M	runtime/vm/intermediate_language.h	View	1 2	3 chunks	+7 lines, -0 lines	0 comments	Download
M	runtime/vm/token.h	View	1	1 chunk	+2 lines, -3 lines	0 comments	Download
M	runtime/vm/token.cc	View	1	1 chunk	+20 lines, -34 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Vyacheslav Egorov (Google)

lgtm https://chromiumcodereview.appspot.com/10536162/diff/1/runtime/vm/intermediate_language.h File runtime/vm/intermediate_language.h (right): https://chromiumcodereview.appspot.com/10536162/diff/1/runtime/vm/intermediate_language.h#newcode505 runtime/vm/intermediate_language.h:505: const Token::Kind token_kind_; Please add a comment that ...

8 years, 6 months ago (2012-06-14 11:24:03 UTC) #2

srdjan

8 years, 6 months ago (2012-06-14 17:14:58 UTC) #3

https://chromiumcodereview.appspot.com/10536162/diff/1/runtime/vm/intermediat...
File runtime/vm/intermediate_language.h (right):

https://chromiumcodereview.appspot.com/10536162/diff/1/runtime/vm/intermediat...
runtime/vm/intermediate_language.h:505: const Token::Kind token_kind_;
On 2012/06/14 11:24:03, Vyacheslav Egorov (Google) wrote:
> Please add a comment that it is expected to be binary op, unary op or kGET for
> getter invocations.

Added comment and assert

Expand Messages | Collapse Messages

Issue 10536162: Add token kind into InstanceCallComp so that we do not need to extract it from name (addresses vego… (Closed)

Description

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Messages